Fix for Java 13 compatibility #23 #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lve breaking code.
|
@markbastian would you be interested in following up on this work now? I can release a new version once this is approved, perhaps by @ztellman ? |
|
Absolutely! I haven't looked at this in ages but it should still be good to go. |
boxxxie
approved these changes
Apr 13, 2022
|
i tested these changes, i'm not sure what the process is for merging, but for the few people who use this lib, i think merging and making a release would be welcome. |
vedang
pushed a commit
to vedang/durable-queue
that referenced
this pull request
May 2, 2023
Fixes Java 13+ compatiblity issues, as noted in clj-commons#23. Copying the relevant parts from the Issue: `java.nio.ByteBuffer` and the other buffer types in `java.nio` now define absolute bulk `get` and `put` methods to transfer contiguous sequences of bytes without regard to or effect on the buffer position. Due to this, running durable-queue against Java 13+ leads to the following error: No matching method put found taking 2 args for class `java.nio.DirectByteBuffer` This commit fixes the problem by adding the relevant type-hints Author: Mark Bastian Ref: https://github.com/markbastian/durable-queue Closes: clj-commons#23 Closes: clj-commons#24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix entailed added type hints to resolve breaking code. All unit tests pass. No reflection errors in core ns. I did not update project dependencies to minimize project changes but this might be a good idea as well.