Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 05-week_5_discussion_questions.md #69

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

vasilislenis
Copy link
Contributor

Key points updated.

Some thoughts about the key points of week 5 material.
Maybe more are needed.

Thanks for contributing!

Please keep in mind that lesson maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at [email protected].


Copy link

github-actions bot commented Sep 4, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries/trainer-training/compare/md-outputs..md-outputs-PR-69

The following changes were observed in the rendered markdown documents:

 05-week_5_discussion_questions.md | 6 ++++--
 md5sum.txt                        | 2 +-
 2 files changed, 5 insertions(+), 3 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-09-05 13:29:02 +0000

@ErinBecker
Copy link
Contributor

These are great @vasilislenis! Thank you so much for this contribution! I've removed the "to be added" line and will merge this in as soon as the checks finish running!

github-actions bot pushed a commit that referenced this pull request Sep 5, 2024
@ErinBecker ErinBecker merged commit f15b0e5 into carpentries:main Sep 5, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 5, 2024
Auto-generated via {sandpaper}
Source  : f15b0e5
Branch  : main
Author  : Erin Becker <[email protected]>
Time    : 2024-09-05 13:32:38 +0000
Message : Merge pull request #69 from vasilislenis/patch-1

Update 05-week_5_discussion_questions.md
github-actions bot pushed a commit that referenced this pull request Sep 5, 2024
Auto-generated via {sandpaper}
Source  : 599ad82
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-09-05 13:33:24 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : f15b0e5
Branch  : main
Author  : Erin Becker <[email protected]>
Time    : 2024-09-05 13:32:38 +0000
Message : Merge pull request #69 from vasilislenis/patch-1

Update 05-week_5_discussion_questions.md
github-actions bot pushed a commit that referenced this pull request Sep 5, 2024
Auto-generated via {sandpaper}
Source  : 599ad82
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-09-05 13:33:24 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : f15b0e5
Branch  : main
Author  : Erin Becker <[email protected]>
Time    : 2024-09-05 13:32:38 +0000
Message : Merge pull request #69 from vasilislenis/patch-1

Update 05-week_5_discussion_questions.md
github-actions bot pushed a commit that referenced this pull request Sep 10, 2024
Auto-generated via {sandpaper}
Source  : 599ad82
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-09-05 13:33:24 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : f15b0e5
Branch  : main
Author  : Erin Becker <[email protected]>
Time    : 2024-09-05 13:32:38 +0000
Message : Merge pull request #69 from vasilislenis/patch-1

Update 05-week_5_discussion_questions.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants