Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overhaul week 1 #60

Merged
merged 1 commit into from
Jul 30, 2024
Merged

overhaul week 1 #60

merged 1 commit into from
Jul 30, 2024

Conversation

ErinBecker
Copy link
Contributor

  • Reframe objectives and keypoints
  • Trim down discussion questions
  • Update figure to match current figure from Instructor Training
  • Add page numbers for readings
  • Remove recommended reading (I think it's overwhelming, and we provide a list of resources on the Etherpad).
  • update links
  • clarify checkout process
  • add Code of Conduct and Introductions

Copy link

github-actions bot commented Jul 30, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries/trainer-training/compare/md-outputs..md-outputs-PR-60

The following changes were observed in the rendered markdown documents:

 01-week1_discussion_questions.md          | 176 ++++++++++++++++--------------
 fig/instructor-training-program.png (new) | Bin 0 -> 100346 bytes
 md5sum.txt                                |   2 +-
 3 files changed, 93 insertions(+), 85 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-07-30 23:34:46 +0000

@ErinBecker ErinBecker merged commit 1b381f6 into carpentries:main Jul 30, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 30, 2024
github-actions bot pushed a commit that referenced this pull request Jul 30, 2024
Auto-generated via {sandpaper}
Source  : 1b381f6
Branch  : main
Author  : Erin Becker <[email protected]>
Time    : 2024-07-30 23:35:19 +0000
Message : Merge pull request #60 from ErinBecker/objectives

overhaul week 1
github-actions bot pushed a commit that referenced this pull request Jul 30, 2024
Auto-generated via {sandpaper}
Source  : e5991ee
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-07-30 23:36:37 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 1b381f6
Branch  : main
Author  : Erin Becker <[email protected]>
Time    : 2024-07-30 23:35:19 +0000
Message : Merge pull request #60 from ErinBecker/objectives

overhaul week 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant