Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classify the mixed and Cofused android samples #119

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

haogg
Copy link

@haogg haogg commented Apr 8, 2015

make those android samples tidy and easy to get and use。

make those android samples tidy and easy to get and use。
@saudet
Copy link
Member

saudet commented Apr 8, 2015

Thanks! That's looking good, but Google itself doesn't support Eclipse anymore, so I feel a sample with Android Studio would be better. Would you have time for that?

@haogg
Copy link
Author

haogg commented Apr 8, 2015

i will do that later。 But time may be weekend。
To be honest,I think android studio is not so stable and quick(this matters more) that it can reach a level that i can put my project on it。
So,i think eclipse version should come first in the near future.

@saudet
Copy link
Member

saudet commented Apr 8, 2015

That's not the point: Eclipse ADT is dead. It won't work with the next version of Android. Besides, with Android Studio, we don't need to include binaries in the source repository. It's better than Eclipse ADT overall.

@haogg
Copy link
Author

haogg commented Apr 8, 2015

That is the trend. It's true.
But it will be a long time until the next version of android is enough popular and stable.
Around me, most of android apps still be developed to be compatibility with Android 4.0.
By the way. eclipse project can be easilly imported into Android Studio,but it is extactly difficult on the contrary. an eclipse project is an android studio project in much words.

So,You see,it is always true that Eclipse project should come first anyway,especially under the circumstances that time is limited.

@saudet
Copy link
Member

saudet commented Apr 8, 2015

Ok, could you at least find a way to remove the binary files? Those don't belong in a source repository. Thanks!

@haogg
Copy link
Author

haogg commented Apr 8, 2015

OK,I will try。In fact,those so files come from jar files that name like 'xxx-arm.jar'。

reduce apk file greatly
@saudet
Copy link
Member

saudet commented Apr 9, 2015

What I meant was: Could you try to remove the binary files, but still keep the project itself functional? Now, if we build the project, it doesn't work, because the binary files are missing. It would be nice to find a way to have them downloaded automatically. Android Studio can do that. I'm sure not we can with Eclipse ADT, but maybe we can add a script file or something to facilitate the installation. Let me know if you figure out something, thanks!

@haogg
Copy link
Author

haogg commented Apr 9, 2015

Thanks for reply.

Before I start my work today,I have something to confirm:

  1. the eclipse project for RecorderActivity I uploaded is sure to work. I test it . But its code needs to be refractored.
    If you can not run it,show me your image or code or some error log?
  2. I still not sure about the functional for one project as you say.
    In the sample project,
    can you figure out the should-be-removed binary files as you think ?
    what are the binary files that should be downloaded automatically in some way? are they the .so files that exist in the \libs\ ? automatically download them by specified platform like arm or x86 in config script?
  3. I think , for a android developer like me , the most important is to figure out the project filled with code that i can easilly run on my phone when i start to explore a masterpeice in Github. And i can easilly know what I can do and can't do. If needed,i would be pleased to contribute back something.
  4. Everything has its evolution progress , so as our sample project.
    First we set up the sample,then we refractor it,then add some cool feature on it.
    ご気分だろう?(<---comes from Youdao dict machine translation) (^o^)/YES!

peel the cameraView from  recorderActivity to a individual one
1.  peel the function of  audio-video-record into a individual
component。
2.  peel the function of Camera into a individual component
This reverts commit 88f55c2.
This reverts commit ecb3d79.
@saudet
Copy link
Member

saudet commented Apr 9, 2015

I'm talking about something like this:
https://github.com/piersy/BasicTesseractExample
Although there is no binaries, we can it run with a single command.
Could you do the same thing for Android?

In any case, I thought instead we could create a new "android-projects" repo here:
https://github.com/bytedeco/
And you could put all that you want there. What do you think?

@haogg
Copy link
Author

haogg commented Apr 9, 2015

I agree with you

@saudet
Copy link
Member

saudet commented Apr 11, 2015

Great! Sorry for the delay. I've finally created a repo named "sample-projects":
https://github.com/bytedeco/sample-projects
Please push your samples there! I guess we could name this one "android-recordactivity"? I feel it's too early to start creating subdirectories. There's not enough samples yet, so it just makes it harder to find your files. When we get many Android samples, for example, and it gets confusing, we can start moving things. What do you think?

@saudet
Copy link
Member

saudet commented Nov 3, 2015

I'm still waiting for your pull request to the https://github.com/bytedeco/sample-projects repository. I will merge it in as soon as I get it, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants