MA-1564: Update native ad manager fork #1

gocampos · 2024-09-25T18:40:46Z

Update the fork with the upstream changes and also include changes from this PR.

How to Test

Clone the app repository and modify the package.json for the "react-native-ad-manager" package to:
"react-native-ad-manager": "https://github.com/businessinsider/react-native-ad-manager#ma-1564-update-native-ad-manager-fork",
Delete the file ios/Podfile.lock.
Run npm install and npx pod-install.
Ensure the app is displaying ads.

Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.3. - [Release notes](https://github.com/yargs/y18n/releases) - [Changelog](https://github.com/yargs/y18n/blob/y18n-v4.0.3/CHANGELOG.md) - [Commits](yargs/y18n@v4.0.0...y18n-v4.0.3) --- updated-dependencies: - dependency-name: y18n dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [ansi-regex](https://github.com/chalk/ansi-regex) from 3.0.0 to 3.0.1. - [Release notes](https://github.com/chalk/ansi-regex/releases) - [Commits](chalk/ansi-regex@v3.0.0...v3.0.1) --- updated-dependencies: - dependency-name: ansi-regex dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [plist](https://github.com/TooTallNate/node-plist) from 3.0.4 to 3.0.6. - [Release notes](https://github.com/TooTallNate/node-plist/releases) - [Changelog](https://github.com/TooTallNate/plist.js/blob/master/History.md) - [Commits](https://github.com/TooTallNate/node-plist/commits) --- updated-dependencies: - dependency-name: plist dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [simple-plist](https://github.com/wollardj/simple-plist) from 1.1.1 to 1.3.1. - [Release notes](https://github.com/wollardj/simple-plist/releases) - [Commits](wollardj/simple-plist@v1.1.1...v1.3.1) --- updated-dependencies: - dependency-name: simple-plist dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](caolan/async@v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [simple-plist](https://github.com/wollardj/simple-plist) from 1.1.1 to 1.3.1. - [Release notes](https://github.com/wollardj/simple-plist/releases) - [Commits](wollardj/simple-plist@v1.1.1...v1.3.1) --- updated-dependencies: - dependency-name: simple-plist dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](caolan/async@v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [parse-url](https://github.com/IonicaBizau/parse-url) from 6.0.0 to 6.0.5. - [Release notes](https://github.com/IonicaBizau/parse-url/releases) - [Commits](IonicaBizau/parse-url@6.0.0...6.0.5) --- updated-dependencies: - dependency-name: parse-url dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2. - [Release notes](https://github.com/SamVerschueren/decode-uri-component/releases) - [Commits](SamVerschueren/decode-uri-component@v0.2.0...v0.2.2) --- updated-dependencies: - dependency-name: decode-uri-component dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [json5](https://github.com/json5/json5) from 2.2.0 to 2.2.3. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v2.2.0...v2.2.3) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 0.7.31 to 0.7.33. - [Release notes](https://github.com/faisalman/ua-parser-js/releases) - [Changelog](https://github.com/faisalman/ua-parser-js/blob/master/changelog.md) - [Commits](faisalman/ua-parser-js@0.7.31...0.7.33) --- updated-dependencies: - dependency-name: ua-parser-js dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/kornelski/http-cache-semantics/releases) - [Commits](https://github.com/kornelski/http-cache-semantics/commits) --- updated-dependencies: - dependency-name: http-cache-semantics dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [react-native](https://github.com/facebook/react-native) from 0.63.3 to 0.64.1. - [Release notes](https://github.com/facebook/react-native/releases) - [Changelog](https://github.com/facebook/react-native/blob/main/Releases.md) - [Commits](facebook/react-native@v0.63.3...v0.64.1) --- updated-dependencies: - dependency-name: react-native dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [react-native](https://github.com/facebook/react-native) from 0.63.4 to 0.64.1. - [Release notes](https://github.com/facebook/react-native/releases) - [Changelog](https://github.com/facebook/react-native/blob/main/CHANGELOG.md) - [Commits](facebook/react-native@v0.63.4...v0.64.1) --- updated-dependencies: - dependency-name: react-native dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [minimist](https://github.com/minimistjs/minimist) from 1.2.5 to 1.2.8. - [Release notes](https://github.com/minimistjs/minimist/releases) - [Changelog](https://github.com/minimistjs/minimist/blob/main/CHANGELOG.md) - [Commits](minimistjs/minimist@v1.2.5...v1.2.8) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>

…react-native-0.64.1 Bump react-native from 0.63.3 to 0.64.1 in /example

…y18n-4.0.3 Bump y18n from 4.0.0 to 4.0.3 in /example

…async-2.6.4 Bump async from 2.6.3 to 2.6.4 in /example

Bump async from 2.6.3 to 2.6.4

…simple-plist-1.3.1 Bump simple-plist from 1.1.1 to 1.3.1 in /example

…list-1.3.1 Bump simple-plist from 1.1.1 to 1.3.1

…-3.0.1

…ansi-regex-3.0.1 Bump ansi-regex from 3.0.0 to 3.0.1 in /example

…plist-3.0.6 Bump plist from 3.0.4 to 3.0.6 in /example

…ssion surfaces onAdRecordImpression to JS

build: bump package version to 2.0.8

…escript-error fixes prepare error for missing declaration

…a: bob build

Changes are to solve errors spit out from command npm run prepare

…rade to support GMA SDK version 10.10.0, also raised the miminum deployment target to ios 12.4.

…ersion to be >=33.

…have to drop GMA SDK version to 22.4.0 as well (from 22.6.0)

…st-gma-sdk-possible upgrade to support newest GMA SDK version possible on both Android and iOS

… so as to make it appear again in the same session

…g-after-user-actions-ios Enabled app interstitials to re-appear after a number of user clicks on iOS

…_and_request Interstitial ads - It shows up only once and isReady crashes on Android

Bump package version to 2.0.10. Include package-lock in repo

…onalizedAds

…d-manager-fork

jbernhardt23

Just want to make sure you were able to test this by changing the package.json library to use this branch https://github.com/businessinsider/react-native-ad-manager#YOUR-BRANCH-NAME

https://github.com/businessinsider/insider-app/blob/235181c5eeb469b39bb9b3cf49477245092dfc11/package.json#L87

dependabot bot and others added 30 commits August 19, 2021 17:01

Add null check around setAdUnitId

13de5ac

Merge pull request NZME#37 from NZME/dependabot/npm_and_yarn/example/…

728294b

…react-native-0.64.1 Bump react-native from 0.63.3 to 0.64.1 in /example

Merge pull request NZME#38 from NZME/dependabot/npm_and_yarn/example/…

0c2902d

…y18n-4.0.3 Bump y18n from 4.0.0 to 4.0.3 in /example

Merge pull request NZME#62 from NZME/dependabot/npm_and_yarn/example/…

06bacab

…async-2.6.4 Bump async from 2.6.3 to 2.6.4 in /example

Merge pull request NZME#63 from NZME/dependabot/npm_and_yarn/async-2.6.4

fa002fe

Bump async from 2.6.3 to 2.6.4

Merge pull request NZME#64 from NZME/dependabot/npm_and_yarn/example/…

1dd2d8a

…simple-plist-1.3.1 Bump simple-plist from 1.1.1 to 1.3.1 in /example

Merge pull request NZME#65 from NZME/dependabot/npm_and_yarn/simple-p…

4a79267

…list-1.3.1 Bump simple-plist from 1.1.1 to 1.3.1

Merge branch 'master' into dependabot/npm_and_yarn/example/ansi-regex…

c3b41ba

…-3.0.1

Merge pull request NZME#67 from NZME/dependabot/npm_and_yarn/example/…

f8116bc

…ansi-regex-3.0.1 Bump ansi-regex from 3.0.0 to 3.0.1 in /example

Merge branch 'master' into dependabot/npm_and_yarn/example/plist-3.0.6

988d0b5

Merge pull request NZME#68 from NZME/dependabot/npm_and_yarn/example/…

3cadd82

…plist-3.0.6 Bump plist from 3.0.4 to 3.0.6 in /example

aleccolville-nzme and others added 24 commits June 22, 2023 10:29

Merge pull request NZME#103 from NZME/feature/surface-ad-record-impre…

2f3f793

…ssion surfaces onAdRecordImpression to JS

Merge pull request NZME#100 from zubko/patch-1

75ead9e

build: bump package version to 2.0.8

fixes prepare error for missing declaration

54c049e

Merge pull request NZME#104 from NZME/bugfix/ad-record-impression-typ…

a6093f6

…escript-error fixes prepare error for missing declaration

Changes are to solve errors spit out from command npm run prepare, ak…

ab72a58

…a: bob build

Merge pull request NZME#105 from NZME/fix/typescript-npm-prepare-error

8baa226

Changes are to solve errors spit out from command npm run prepare

1. on Android, upgrade to support GMA SDK version 22.6.0; on iOS, upg…

9c3505a

…rade to support GMA SDK version 10.10.0, also raised the miminum deployment target to ios 12.4.

according to release note, for GMA SDK 22.6.0, it requires compleSdkV…

ae63a39

…ersion to be >=33.

because the external GDPR module only supports GMA SDK 22.4.0, so we …

1618dcf

…have to drop GMA SDK version to 22.4.0 as well (from 22.6.0)

Merge pull request NZME#120 from NZME/feature/upgrade-to-support-newe…

38af969

…st-gma-sdk-possible upgrade to support newest GMA SDK version possible on both Android and iOS

fix(iOS): requestAd method condition

74ff39b

fix(android): isReady callback param

00024ce

fix: typescript isReady callback param type from number to boolean

b0779e2

Re-initialised interstitial object every time the user closes it out,…

3f5e432

… so as to make it appear again in the same session

Merge pull request NZME#126 from NZME/bugfix/interstitial-ad-appearin…

de56f16

…g-after-user-actions-ios Enabled app interstitials to re-appear after a number of user clicks on iOS

Merge pull request NZME#125 from gladiuscode/fix/interstials_is_ready…

8413784

…_and_request Interstitial ads - It shows up only once and isReady crashes on Android

Bump package version to 2.0.10. Include package-lock in repo

f84b904

Merge pull request NZME#127 from NZME/chore/2.0.10

d4bdf22

Bump package version to 2.0.10. Include package-lock in repo

feat(js): setup javascript layer with new property servePersonalizedAds

1be0bff

feat(iOS): setup iOS native layer with new property servePersonalizedAds

89ba773

feat(android): setup Android native layer with new property servePers…

a5c4112

…onalizedAds

fix(android): missing bundle and admobadapter imports

362e0c3

feat: force use of restricted data

0880168

Merge branch 'gladiuscode-fix-issue-130' into ma-1564-update-native-a…

4583bb8

…d-manager-fork

gocampos marked this pull request as ready for review October 1, 2024 23:58

gocampos requested review from jbernhardt23, mincer-ray and gtcaras October 1, 2024 23:58

jbernhardt23 approved these changes Oct 2, 2024

View reviewed changes

gocampos merged commit 5d37626 into master Oct 7, 2024
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MA-1564: Update native ad manager fork #1

MA-1564: Update native ad manager fork #1

gocampos commented Sep 25, 2024 •

edited

Loading

jbernhardt23 left a comment •

edited

Loading

MA-1564: Update native ad manager fork #1

MA-1564: Update native ad manager fork #1

Conversation

gocampos commented Sep 25, 2024 • edited Loading

jbernhardt23 left a comment • edited Loading

Choose a reason for hiding this comment

gocampos commented Sep 25, 2024 •

edited

Loading

jbernhardt23 left a comment •

edited

Loading