Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PHP 8.3 #141

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Support PHP 8.3 #141

merged 1 commit into from
Nov 24, 2023

Conversation

deleugpn
Copy link
Member

No description provided.

@mnapoli
Copy link
Member

mnapoli commented Nov 23, 2023

I'm confused, should we close this one since #142 was merged?

@deleugpn
Copy link
Member Author

I merged #142 into my branch because I'm using that branch temporarily, but this is targeting master directly. When I finish #131, this should not cause any conflict because it is the exact same change so git will sort it out by itself.

@mnapoli
Copy link
Member

mnapoli commented Nov 24, 2023

oh 🤦 I forgot how to git

Sounds good!

@mnapoli mnapoli merged commit 2bff7e6 into master Nov 24, 2023
24 checks passed
@mnapoli mnapoli deleted the support-php-83 branch November 24, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillkruss tillkruss tillkruss approved these changes

@mnapoli mnapoli mnapoli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deleugpn @mnapoli @tillkruss