-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-13396] Add support for legacy error response model in getToken #4112
base: main
Are you sure you want to change the base?
Conversation
0d99464
to
44863b2
Compare
New Issues
Fixed Issues
|
44863b2
to
1aedde6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4112 +/- ##
=======================================
Coverage 88.89% 88.89%
=======================================
Files 436 436
Lines 37702 37702
Branches 5281 5281
=======================================
Hits 33515 33515
Misses 2342 2342
Partials 1845 1845 ☔ View full report in Codecov by Sentry. |
...src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/model/GetTokenResponseJson.kt
Outdated
Show resolved
Hide resolved
1aedde6
to
cd1414f
Compare
...src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/model/GetTokenResponseJson.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit adds support for the legacy error response model returned by the `getToken` endpoint. The legacy model uses lowercase keys for error messages, while the current model uses uppercase keys. This change ensures that the app can handle both models correctly. Additionally, the unit tests were updated to cover the scenario where the server returns a legacy error response.
cd1414f
to
b55741a
Compare
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13396
📔 Objective
This commit adds support for the legacy error response model returned by the
getToken
endpoint.The legacy model uses lowercase keys for error messages, while the current model uses uppercase keys. This change ensures that the app can handle both models correctly.
Additionally, the unit tests were updated to cover the scenario where the server returns a legacy error response.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes