Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/clickhouse] Allow change ClickHouse cluster name #29939

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ss098
Copy link

@ss098 ss098 commented Oct 16, 2024

Description of the change

Allow changing the name of the ClickHouse cluster via Helm value.

Benefits

This change enables users to customize the ClickHouse cluster name, which is particularly useful for integrating with applications like SigNoz that require a specific cluster name setup.

Possible drawbacks

Applicable issues

Additional information

I am trying to use Bitnami ClickHouse as the External ClickHouse for SigNoz. Due to restrictions mentioned in the SigNoz documentation, I need to change the Bitnami ClickHouse's cluster name, which is currently hardcoded as default.

Distributed cluster named cluster set up required

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@ss098 ss098 force-pushed the feat/clickhouse-cluster-name branch from 13f2c95 to 312923f Compare October 16, 2024 12:38
Signed-off-by: Bitnami Containers <[email protected]>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Oct 16, 2024
@github-actions github-actions bot removed the triage Triage is needed label Oct 16, 2024
@github-actions github-actions bot removed the request for review from carrodher October 16, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clickhouse in-progress verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants