-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added color prop to the Tag
component
#2338
Conversation
just absolutely awesome!
@Tsudhishnair _a please use this URL to review. I have built a custom component to help with the PR review. Here, I have used all the colors provided by the GitHub labels color palette by default. I have added a color picker to test it with different colors. Light mode Dark mode
@Tsudhishnair please have a look at the UI and LMK:
|
@praveen-murali-ind _A Self-assigning to work on the colors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AbhayVAshokan _a, as discussed on the call, let’s remove the new color
prop and use the existing style
prop instead.
As per the discussion, I am closing this PR. We will add new styles as part of the Tag component and the colors will be added as new styles. |
Tag
component #2337Description
color
prop to theTag
component.Checklist
I have added tests that prove my fix is effective or that my feature works.I have added properdata-cy
anddata-testid
attributes.patch
/minor
/major
- If package publishis required).
Reviewers
@AbhayVAshokan _a
patch _t