New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled click in selected option close button if select is disabled #1770

Merged

praveen-murali-ind merged 1 commit into main from 1748-item-should-not-be-removable-when-disabled

Aug 2, 2023

Contributor

amaldinesh7 commented Aug 1, 2023 •

edited

Loading

Fixes Items should not be removable in a disabled multi select component #1748

Description

Fixed: Disabled click in selected option close button if select is disabled.

Checklist

I have made corresponding changes to the documentation.
I have updated the types definition of modified exports.
I have verified the functionality in some of the neeto web-apps.
I have added tests that prove my fix is effective or that my feature works
I have added the necessary label (patch/minor/major - If package publish
is required).

Reviewers
@praveen-murali-ind _a Please review.


          Disabled click in selected option close button if select is disabled

e550b6f

amaldinesh7 added the patch label

neetogit-bot bot assigned praveen-murali-ind

unnitallman deployed to neeto-ui-pr-1770

August 1, 2023 17:34

View deployment

praveen-murali-ind approved these changes

View reviewed changes

praveen-murali-ind merged commit 1f1eb26 into main

praveen-murali-ind deleted the 1748-item-should-not-be-removable-when-disabled branch

August 2, 2023 15:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch