Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed warnings in jest tests #1744

Merged
merged 4 commits into from
Jul 12, 2023
Merged

Conversation

CalvinChiramal
Copy link
Contributor

Description
Fixed warnings in jest tests.

Checklist

  • [ ] I have made corresponding changes to the documentation.
  • [ ] I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added the necessary label (patch/minor/major - If package publish
    is required).

@CalvinChiramal CalvinChiramal linked an issue Jul 7, 2023 that may be closed by this pull request
@unnitallman unnitallman temporarily deployed to neeto-ui-pr-1744 July 7, 2023 12:23 Inactive
@CalvinChiramal
Copy link
Contributor Author

@ajmaln _a. Please review.
Tippy.js/react does not have the props onClose or distance so adding them in our components was useless.
I removed onClose from src/components/Dropdown/index.jsx and distance from src/components/layouts/Sidebar/NavIconWrapper.jsx.

@CalvinChiramal CalvinChiramal marked this pull request as ready for review July 7, 2023 12:35
Copy link
Contributor

@ajmaln ajmaln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Calvinwilson99 _a As discussed over call

  • Add a plugin with name onClose on tippy.
  • Remove the added div from Tooltip
  • Move the divs to the tests
  • Add div around Sidebar NavIconsWrapper

@neetogit-bot neetogit-bot bot assigned CalvinChiramal and unassigned ajmaln Jul 10, 2023
@unnitallman unnitallman temporarily deployed to neeto-ui-pr-1744 July 10, 2023 13:13 Inactive
@unnitallman unnitallman temporarily deployed to neeto-ui-pr-1744 July 10, 2023 13:25 Inactive
@CalvinChiramal
Copy link
Contributor Author

@ajmaln _a. Please check. Made the suggested changes.

@neetogit-bot neetogit-bot bot assigned ajmaln and unassigned CalvinChiramal Jul 10, 2023
Copy link
Contributor

@ajmaln ajmaln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@praveen-murali-ind _a Please review

@neetogit-bot neetogit-bot bot assigned praveen-murali-ind and unassigned ajmaln Jul 10, 2023
Copy link
Contributor

@praveen-murali-ind praveen-murali-ind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajmaln @Calvinwilson99 _a LGTM.

@ajmaln ajmaln added the patch Releases small requests or bug fixes. label Jul 11, 2023
@ajmaln ajmaln merged commit 8aabacb into main Jul 12, 2023
@ajmaln ajmaln deleted the 1743-fix-warnings-when-running-unit-tests branch July 12, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Releases small requests or bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix warnings when running unit tests
4 participants