Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mas i1121 reip3 #1838

Merged
merged 8 commits into from
Dec 6, 2022
Merged

Mas i1121 reip3 #1838

merged 8 commits into from
Dec 6, 2022

Conversation

martinsumner
Copy link
Contributor

Add a reip_manual/1 function to riak_kv_console that allows reip to be done with knowledge of ring_sir and cluster name - avoiding the need to load riak_core.

basho/riak_core#992

basho/riak#1121

@hmmr
Copy link
Contributor

hmmr commented Dec 6, 2022

+1

@martinsumner martinsumner merged commit 159df40 into develop-3.0 Dec 6, 2022
@martinsumner martinsumner deleted the mas-i1121-reip3 branch December 6, 2022 18:18
martinsumner added a commit that referenced this pull request Dec 19, 2022
* Add reip/3

To allow for reip without loading the riak_core application

* Use alternate name

* Update riak_kv_console.erl

* Update riak_kv_console.erl

* reip_manual inputs are atoms

* Add warning to update riak.conf file after reip

* Make clear where attention is required

And return 'ok' to make clear the op was successful

* Update rebar.config
martinsumner added a commit that referenced this pull request Dec 19, 2022
* Do not crash when object's contents is an empty list (#1837)

* Add test to illustrate issue

* Do not crash when object's contents is an empty list

* add missing function clause repair_keys_range in convert_fold (#1839)

* add missing function clause repair_keys_range in convert_fold, to unbreak aae_fold for that case

* thread converted aae_fold query in riak_client, to complete prev commit

* Change the default PR value from 0 to default (#1836)

This means that get requests will use bucket-type level Primary Read settings

Co-authored-by: Peter Tihanyi <[email protected]>

* Mas i1121 reip3 (#1838)

* Add reip/3

To allow for reip without loading the riak_core application

* Use alternate name

* Update riak_kv_console.erl

* Update riak_kv_console.erl

* reip_manual inputs are atoms

* Add warning to update riak.conf file after reip

* Make clear where attention is required

And return 'ok' to make clear the op was successful

* Update rebar.config

* Update log (#1840)

Make situation clearer in log

Rather than change behaviour, just make it clear that the warning can be ignored when shutting down.  This should avoid unnecessary concern.

* Update Readme, remove mercurial refs

Co-authored-by: Enrique Fernández <[email protected]>
Co-authored-by: Andrei Zavada <[email protected]>
Co-authored-by: Peter Tihanyi <[email protected]>
Co-authored-by: Peter Tihanyi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants