Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1991: add support for 'clear screen' and 'move to home' #1992

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wodzuu
Copy link

@wodzuu wodzuu commented Apr 3, 2023

Motivation

Implement feature requested in Issue #1991

Change description

A complete rewrite of messagesToLines from monitor-utils.ts

Other information

Docs have not been updated as there are no docs related to the Serial Monitor

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@CLAassistant
Copy link

CLAassistant commented Apr 3, 2023

CLA assistant check
All committers have signed the CLA.

@kittaakos
Copy link
Contributor

Hi @wodzuu, thanks for the contribution. What IDE2 needs, in the long run, is a pseudoterminal: #1473 (comment).

@wodzuu
Copy link
Author

wodzuu commented Apr 4, 2023

Hi @kittaakos. Yes, that would be perfect. However this seems to be a much bigger task than just adding support for those two escape sequences. And I think they already make a significant difference (for me at least :P )

@kittaakos kittaakos added type: enhancement Proposed improvement topic: serial monitor Related to the Serial Monitor labels Apr 10, 2023
@per1234 per1234 added the topic: code Related to content of the project itself label Jun 11, 2023
@Shumatic
Copy link

Shumatic commented Jul 5, 2023

Hi @kittaakos.
As there a lot of whises for Serial, wouldn't it be easier to use an external monitor as YAT, it provide mutch of the fuctionallity that users ask for.
For OTA devices it is easy, as they can upload with Serial connected.
For other bords we need a way to disable the external Serial monitor while uploading. Just a thought.....

@kittaakos
Copy link
Contributor

kittaakos commented Jul 5, 2023

wouldn't it be easier to use an external monitor as YAT,

For OTA devices it is easy, as they can upload with Serial connected.
For other bords we need a way to disable the external Serial monitor while uploading. Just a thought.....

No, I do not think so.

IDE2 never talks with the board directly on serial or other ways. The Arduino CLI knows how to talk to the board and acts as a middleman between the device and the IDE. It wouldn't be easier to integrate an external tool with IDE2, especially since YAT is for Windows only, as I see, and we want to make the features available to all users.

Furthermore, it seems to be possible without any external tools (#1473 (comment)):

use a Pseudoterminal from VS Code.

monitor_running_in_terminal.mp4

I have another ongoing implementation, which uses the monaco editor. See #105.

Please bear with us; do not think we do not hear your voice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself topic: serial monitor Related to the Serial Monitor type: enhancement Proposed improvement
Projects
None yet
5 participants