Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use buf.build to manage our protobuf related activities #2736

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

alessio-perugini
Copy link
Contributor

@alessio-perugini alessio-perugini commented Oct 18, 2024

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Use buf to manage the compilation, lint, formatting, breaking change detection of our protobuf files

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

If this PR gets approved I will also have to update our template repo

@alessio-perugini alessio-perugini linked an issue Oct 18, 2024 that may be closed by this pull request
3 tasks
Copy link
Contributor

github-actions bot commented Oct 18, 2024

The latest Buf updates on your PR. Results from workflow Check Protocol Buffers / check (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedOct 18, 2024, 4:49 PM

@alessio-perugini alessio-perugini force-pushed the 2422-add-an-automation-to-detect-protobuf-breaking-changes branch from 8f8fd5b to 9496a56 Compare October 18, 2024 16:18
@alessio-perugini alessio-perugini self-assigned this Oct 18, 2024
@alessio-perugini alessio-perugini added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Oct 18, 2024
@alessio-perugini alessio-perugini force-pushed the 2422-add-an-automation-to-detect-protobuf-breaking-changes branch from 9496a56 to dc2c67a Compare October 18, 2024 16:23
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.65%. Comparing base (a527c7c) to head (573fdb0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2736      +/-   ##
==========================================
- Coverage   67.67%   67.65%   -0.02%     
==========================================
  Files         236      236              
  Lines       22327    22327              
==========================================
- Hits        15109    15106       -3     
- Misses       6030     6032       +2     
- Partials     1188     1189       +1     
Flag Coverage Δ
unit 67.65% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alessio-perugini alessio-perugini marked this pull request as ready for review October 18, 2024 16:49
@alessio-perugini alessio-perugini changed the title 2422 add an automation to detect protobuf breaking changes Use buf.build to manage our protobuf related activities Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an automation to detect protobuf breaking changes
1 participant