[MNG-8331] Mix of the two fixes #1823
Closed
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't do anything if not needed. --- https://issues.apache.org/jira/browse/MNG-8331
This was referenced Oct 19, 2024
gnodet
reviewed
Oct 19, 2024
| } | ||
| } | ||
| return modified ? model.withDependencies(newDeps) : model; | ||
| return model.withDependencies(newDeps); |
There was a problem hiding this comment.
model.withDependencies() will always create a new object if not modified.
I don't see why this would be needed.
|
Closing my "mix" draft to favor one of existing PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't do anything if not needed.
https://issues.apache.org/jira/browse/MNG-8331