src/butil: correct assign atomic pointer member to be NULL #2003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. memset assign value to var without considering var type. 2. memset can't guarantee atomic operation Signed-off-by: Liu, Changcheng <[email protected]>
|
@changchengx Do you have any problem using memset ? (eg. compile error or unexpected behavior at runtime) |
|
@wwbmmm No. From semantic perspective, memset doesn't consider variable type at all and guarantee atomic operation. |
|
Could you please submit the application scenario of brpc in your company? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Liu, Changcheng [email protected]