Support notifying bank created slot status in geyser #3126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lijunwangs
force-pushed
the
support_notify_bank_created_in_geyser
branch
from
c195658
to
2048633
Compare
lijunwangs
requested review from
CriesofCarrots,
bw-solana,
t-nelson and
sakridge
bw-solana
approved these changes
Oct 14, 2024
| @@ -9023,6 +9047,7 @@ pub(crate) mod tests { | |||
| &poh_recorder, | |||
| &leader_schedule_cache, | |||
| &rpc_subscriptions, | |||
| &None, | |||
There was a problem hiding this comment.
Can we add/modify a test that provides a SlotStatusNotifier to get some coverage?
There was a problem hiding this comment.
Will handle it in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This is the 3rd part to support more slot status notification type in geyser. CreatedBank on new fork creation.
Summary of Changes
Link SlotStatusNotifier in replay stage on CreatedBank.
Tests: tested change with Postgres geyser plugin and confirming the CreatedBank being received.
Fixes #
#2957