Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Dispatcher a singleton after first instantiation #343

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make Dispatcher a singleton after first instantiation #343

wants to merge 1 commit into from

Conversation

kurtmckee
Copy link
Contributor

This allows plugins to re-instantiate the Dispatcher (or, now, use the instance cached in current_dispatcher) without knowing what plugins have been loaded by dotbot.

This fixes plugins that want to dispatch to other plugins.

Fixes #339

@kurtmckee kurtmckee mentioned this pull request Jul 28, 2023
Open
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2023 •
edited
Loading

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@kurtmckee kurtmckee mentioned this pull request Jul 28, 2023
Open
@kurtmckee
Copy link
Contributor Author

kurtmckee commented Jul 28, 2023 •
edited
Loading

Test suite is failing due to PyYAML 5 and Cython 3. There is currently no way to trivially resolve this.

The test suite is passing after rebasing on master and resolving merge conflicts.

@kurtmckee kurtmckee mentioned this pull request Jul 31, 2023
Closed
@erikw
Copy link

erikw commented Aug 1, 2023

@kurtmckee many thanks! I can confirm that with this PR, plugins like dotbot-if works (wonderbeyond/dotbot-if#1) 🚢 :shipit:

@kurtmckee
Make Dispatcher a singleton after first instantiation
2549772 
This allows plugins to re-instantiate the Dispatcher
(or, now, use the instance cached in `current_dispatcher`)
without knowing what plugins have been loaded by dotbot.

This fixes plugins that want to dispatch to other plugins.

Fixes anishathalye#339
@kurtmckee kurtmckee force-pushed the resolve-dispatcher-plugins-failure-issue-339 branch from c011505 to 2549772 Compare September 10, 2023 15:09
@kurtmckee
Copy link
Contributor Author

Rebased on master and resolved merge conflicts. The test suite passes now.

@erikw
Copy link

erikw commented Oct 21, 2023

I would be delighted if we could get this merged!

@kurtmckee
Copy link
Contributor Author

@anishathalye I hope you're doing well! If you have an opportunity to take a look at this and see anything that needs to be modified please let me know. 👍

@kurtmckee
Copy link
Contributor Author

@anishathalye Friendly ping. 😁

@kurtmckee
Copy link
Contributor Author

Fixes #357

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

All plugins using sub-directives implemented with Dispatcher broken
3 participants
@kurtmckee @codecov-commenter @erikw