#165273536: Pagination support for articles #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalsmic
requested review from
bisonlou,
ZackAtama,
nadralia,
JamesMudidi and
llwasampijja
houndci-bot
reviewed
Jun 20, 2019
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
The configured stylelint version is not supported.
The configured stylelint version is not supported. See a list of supported versions on our docs page.
houndci-bot
reviewed
Jun 20, 2019
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
The configured stylelint version is not supported.
The configured stylelint version is not supported. See a list of supported versions on our docs page.
| @@ -0,0 +1,65 @@ | |||
| // react | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
Parsing error: 'import' and 'export' may appear only with 'sourceType: module'
| @@ -0,0 +1,49 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
Parsing error: 'import' and 'export' may appear only with 'sourceType: module'
kalsmic
force-pushed
the
feat-article-pagination-165273536
branch
from
03d44f1
to
2063e73
Compare
houndci-bot
reviewed
Jun 20, 2019
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
The configured stylelint version is not supported.
The configured stylelint version is not supported. See a list of supported versions on our docs page.
houndci-bot
reviewed
Jun 20, 2019
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
The configured stylelint version is not supported.
The configured stylelint version is not supported. See a list of supported versions on our docs page.
- add article pagination - Revise article like count prop validation from array to object since it has been modified in the back end [starts #165273536]
kalsmic
force-pushed
the
feat-article-pagination-165273536
branch
from
2063e73
to
3c51443
Compare
houndci-bot
reviewed
Jun 20, 2019
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
The configured stylelint version is not supported.
The configured stylelint version is not supported. See a list of supported versions on our docs page.
houndci-bot
reviewed
Jun 20, 2019
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
The configured stylelint version is not supported.
The configured stylelint version is not supported. See a list of supported versions on our docs page.
houndci-bot
reviewed
Jun 20, 2019
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
The configured stylelint version is not supported.
The configured stylelint version is not supported. See a list of supported versions on our docs page.
nadralia
reviewed
Jun 21, 2019
| @@ -115,15 +156,25 @@ LandingPage.defaultProps = { | |||
| * @return {articles} - An aray of articles | |||
| * | |||
| */ | |||
| const mapStateToProps = state => state.articles; | |||
| // const mapStateToProps = state => state.articles; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of Task to be completed?
How should this be manually tested?
Any background context you want to provide?
since it has been modified in the back end.
What are the relevant pivotal tracker stories?
Screenshots (if appropriate)