#165273545: Viewing read time for Articles or an Article #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit adds a feature for creating an article files contained in this commit; - Articles folder that contains the js and scss for articles pages [Maintains #165273532]
this commit adds a feature for getting an article included in this commit; - UI design for an article page [Maintains #165273532]
this commit adds a feature for creating an article
files contained in this commit;
- Articles folder that contains the js and scss for articles pages
[Maintains #165273532]
this commit adds a feature for viewing all articles [Maintains #165273532]
this commit does the following; - adds feature creating an article - adds feature for getting all articles
this commit adds the following features to the application; - a feature for creating an article - a feature for getting all articles - a feature for getting an article - all features added have UI pages they are linked to [Maintains #165273532]
this commit adds a feature for seeing the read time of an article [Maintains #165273545]
houndci-bot
reviewed
Jun 19, 2019
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
The configured stylelint version is not supported.
The configured stylelint version is not supported. See a list of supported versions on our docs page.
houndci-bot
reviewed
Jun 19, 2019
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
The configured stylelint version is not supported.
The configured stylelint version is not supported. See a list of supported versions on our docs page.
| export const axiosConfig = { | ||
| headers: { | ||
| 'Content-Type': 'application/json', | ||
| Authorization: `Bearer ${sessionStorage.getItem('ahToken')}`, |
There was a problem hiding this comment.
'sessionStorage' is not defined no-undef
| export const baseURL = 'https://ah-backend-dojo-dev.herokuapp.com/api'; | ||
|
|
||
| export const defaultImgURL = 'https://ah-frontend-dojo.herokuapp.com/src/asset'; | ||
| export const author = sessionStorage.getItem('username'); |
There was a problem hiding this comment.
'sessionStorage' is not defined no-undef
| expect(newState.articles.length).toEqual(0); | ||
| }); | ||
|
|
||
| it('Should return the passed state', () => { | ||
| const newState = articles(initialSate, generatePayload(GET_ARTICLES)); | ||
| const newState = articlesReducer(initialSate, generatePayload(GET_ARTICLES)); | ||
| expect(newState.articles.length).toEqual(0); |
| }); | ||
|
|
||
| it('should edit an article', () => { | ||
| expect( |
| }); | ||
|
|
||
| it('should edit an article', () => { | ||
| expect( |
| import { getAllArticles } from 'store/actions/articleActions'; | ||
| import { GET_ARTICLES, GET_ARTICLES_START } from '../articleTypes'; | ||
| import { getAllArticles, newArticle } from 'store/actions/articleActions'; | ||
| import data from 'store/actions/__mocks__'; |
There was a problem hiding this comment.
'data' is defined but never used no-unused-vars
| import thunk from 'redux-thunk'; | ||
| import { getAllArticles } from 'store/actions/articleActions'; | ||
| import { GET_ARTICLES, GET_ARTICLES_START } from '../articleTypes'; | ||
| import { getAllArticles, newArticle } from 'store/actions/articleActions'; |
There was a problem hiding this comment.
'newArticle' is defined but never used no-unused-vars
| getArticle(slug); | ||
| } | ||
|
|
||
| fetchArticle = (e) => { |
| export default class Search extends Component { | ||
| render() { | ||
| return ( | ||
| <div className="searchPanel"> |
| import React from 'react'; | ||
| import './Loader.scss'; | ||
|
|
||
| const ProgressLoader = () => <div className="progress__loader" />; |
ZackAtama
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of Task to be completed?
How should this be manually tested?
npm installnpx jest --coverage -unpm run devAny background context you want to provide?
What are the relevant pivotal tracker stories?
-165273545
Screenshots (if appropriate)
Read time display for all articles
Read time display for an article