Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapcraft: update to core22 #132

Merged
merged 1 commit into from
Aug 11, 2023
Merged

snapcraft: update to core22 #132

merged 1 commit into from
Aug 11, 2023

Conversation

mitchdz
Copy link
Contributor

@mitchdz mitchdz commented Aug 10, 2023

Tested this snap on Ubuntu 22.04.3.

Everything works right now except Disk usage.

@mitchdz
Copy link
Contributor Author

mitchdz commented Aug 11, 2023

Upon further testing, there's an issue with this snap build as it constantly polls disk usage which isn't allowed, therefore journalctl gets filled with lines like

Aug 10 21:11:11 light audit[3475869]: AVC apparmor="ALLOWED" operation="ptrace" class="ptrace" profile="snap.gtop.gtop" pid=3475869 comm="cat" requested_mask="read" denied_mask="read" peer="unconfined"

@aksakalli
Copy link
Owner

Hi @mitchdz,

Thanks for the contribution and trying to fix the broken snap builds. Could you also fix the broken badge link? I am not what is the replacement for this line:

[![Snap Status](https://build.snapcraft.io/badge/aksakalli/gtop.svg)](https://build.snapcraft.io/user/aksakalli/gtop)

@mitchdz
Copy link
Contributor Author

mitchdz commented Aug 11, 2023

@aksakalli Sure, I'll take a look into that!

Also just fixed the issue with journalctl by just using --classic confinement for now. This also fixes not being able to read disk usage, so all gtop functionality remains the same.

I'd like to be able to get the app working with strict confinement but sounds like a future improvement kind of thing.

@mitchdz
Copy link
Contributor Author

mitchdz commented Aug 11, 2023

@aksakalli could you try looking in https://snapcraft.io/gtop/publicise? That link should have the badge code, but I don't have access to the namespace

@aksakalli
Copy link
Owner

@aksakalli could you try looking in https://snapcraft.io/gtop/publicise? That link should have the badge code, but I don't have access to the namespace

thanks for the link, I merged #133 for that change.

I'd like to be able to get the app working with strict confinement but sounds like a future improvement kind of thing.

Shall we merge it then?

@mitchdz
Copy link
Contributor Author

mitchdz commented Aug 11, 2023

I'd say it's good to go! Been testing it with --classic confinement for ~2hrs while doing other CPU/disk intensive work and gtop is working fine.

@aksakalli aksakalli merged commit 0406441 into aksakalli:master Aug 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants