Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force Channel Check is Stopping SponsorBlock from Skipping Ads #698

Closed
leganrac opened this issue Mar 24, 2021 · 1 comment · Fixed by #738
Closed

Force Channel Check is Stopping SponsorBlock from Skipping Ads #698

leganrac opened this issue Mar 24, 2021 · 1 comment · Fixed by #738

Comments

@leganrac
Copy link

Sorry for the really long and weirdly capitalized title.
When "forceChannelCheck": true, the addon will be unable to actually skip the sponsors, and will instead continue the video.
See also: This Reddit post describing the issue
@ajayyy ajayyy mentioned this issue Mar 24, 2021
Closed
@ajayyy
Copy link
Owner

ajayyy commented Mar 24, 2021 •
edited
Loading

See #635 #611

A warning should be shown if the channel request fails after X seconds.

ajayyy added a commit that referenced this issue Mar 25, 2021
@ajayyy
Prompt to accept youtube.com permission if video info fails to load
3ff5fdb 
Should fix #698, #687, #611 and #635
ajayyy added a commit that referenced this issue May 10, 2021
@ajayyy
Prompt to accept youtube.com permission if video info fails to load
bf84139 
Should fix #698, #687, #611 and #635

(cherry picked from commit 3ff5fdb)
@ajayyy ajayyy mentioned this issue May 10, 2021
Merged
ajayyy added a commit that referenced this issue May 9, 2023
@ajayyy
Prompt to accept youtube.com permission if video info fails to load
9122a1e 
Should fix #698, #687, #611 and #635
ajayyy added a commit that referenced this issue May 9, 2023
@ajayyy
Prompt to accept youtube.com permission if video info fails to load
c5f9fd1 
Should fix #698, #687, #611 and #635

(cherry picked from commit 3ff5fdb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prompt to accept youtube.com permission if video info fails to load ajayyy/SponsorBlock
2 participants
@ajayyy @leganrac