Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not skipping on any videos #611

Closed
AntiSol opened this issue Jan 8, 2021 · 33 comments
Closed

Not skipping on any videos #611

AntiSol opened this issue Jan 8, 2021 · 33 comments

Comments

@AntiSol
Copy link

AntiSol commented Jan 8, 2021

This may be something you're already aware of, apologies if it is.

I'm seeing issues with sponsorblock on youtube. it looks like they've updated their player and that the new player isn't working with sponsorblock.

The new player has an "autoplay" button between the regular close caption button and sponsorblock's "segment starts now" button.

it seems that ever since this new player took effect, sponsorblock isn't working anymore. As an example, I added a couple of segments to https://www.youtube.com/watch?v=OytOJdGsrA0 but when I watch the video sponsorblock is not skipping them.

I'm running sponsorblock in Waterfox classic 2020.12 (64-bit).

@AntiSol
Copy link
Author

AntiSol commented Jan 13, 2021

...no response at all? am I missing something really obvious? is my description unclear? is nobody else seeing the same issue?

Sponsorblock is currently completely useless to me as a result of this, has been for about a week...

sponsorblock.mp4

@t1g3pf4c3
Copy link

Same issue. Checked plugin preferences and all firefox addons. Nothing works. SponsorBlock just mark segments, but can't skip it

@ajayyy
Copy link
Owner

ajayyy commented Jan 14, 2021

@t1g3pf4c3 which browser version?

@t1g3pf4c3
Copy link

@ajayyy Firefox 84.0.2

@UserNaem
Copy link

Tried Firefox 84, Firefox 56, Waterfox 56.2.14, no issues to report, everything works fine here. Try making a new profile in about:profiles.

@t1g3pf4c3
Copy link

@UserNaem thanks a lot. Switching to new profile worked for me. Looks like it's just my firefox issues

@prediscover
Copy link

prediscover commented Jan 30, 2021

Sponsorblock broken for me, firefox 85 :( Going to see if it's the profile

Edit: yep, sponsorblock works when installed in a new profile.
I don't get how it broke though, when I didn't' touch anything. I wonder what broke it. @t1g3pf4c3

@ajayyy
Copy link
Owner

ajayyy commented Jan 30, 2021

Next person who experiences this, please go the options and copy the debug info before making a new profile.

@RobertHoueland
Copy link

This is happening to me, here's my debug info.
debug_info.txt

@ajayyy
Copy link
Owner

ajayyy commented Feb 2, 2021

I unfortunately can't reproduce it with your config

@RobertHoueland
Copy link

Weird, it might be an addon problem for me, it only happens sometimes.

@ajayyy
Copy link
Owner

ajayyy commented Feb 3, 2021

@therobdog7 oh, that's a different problem then. Do you have video speed?

@ajayyy ajayyy changed the title updated youtube player breaks sponsorblock Not skipping on any videos Feb 3, 2021
@RobertHoueland
Copy link

Yes, do they conflict with each other?

@ajayyy
Copy link
Owner

ajayyy commented Feb 3, 2021

@therobdog7 Yes. Until they merge my pull request into their extension (igrigorik/videospeed#740), changing the speed using that extension will break it. However, you can easily work around this by pausing/playing the video after every speed change so that SponsorBlock knows to update the video's speed.

@RobertHoueland
Copy link

Great, thank you

@lilyremigia
Copy link

lilyremigia commented Feb 22, 2021

For me, it breaks when installed in default profile for Linux.

@purplpasta
Copy link

Same problem here. I have the "Enhancer for YouTube™" add-on, is that the source of the problem? If yes, is there any workaround (since pausing and un-pausing doesn't do anything)

What's confusing me is that I have skipped some segments already. Can't recall any since most of the time I have YouTube running in the background, but I installed the Enhancer for YT before Sponsorblock

@Ryanlie
Copy link

Ryanlie commented Mar 11, 2021

Disabling every other add-on, and enabling it one by one seems to fix it

@MoiraPrime
Copy link

I had this issue and by trying various things I managed to fix it by opening up the permissions page and enabling it to work for all sites.
image

Whenever I turned this setting off, it stopped working again. No clue why this is the case, but hopefully this will help someone.

@AntiSol
Copy link
Author

AntiSol commented Mar 18, 2021

where is that page? my sponsorblock settings look completely different and I don't see that option anywhere

@MoiraPrime
Copy link

This is on the addons page. Click on the add-on in the list.
image
Then click on the permissions button.
image

@AntiSol
Copy link
Author

AntiSol commented Mar 18, 2021

still don't see that

@AntiSol
Copy link
Author

AntiSol commented Mar 18, 2021

and apparently github is broken and won't let me attach files anymore, so:
https://antisol.org/Screenshot_2021-03-18_14-24-54.jpg

@unbeatable-101
Copy link

What shows up when you click preferences?

@AntiSol
Copy link
Author

AntiSol commented Mar 18, 2021

@Mattwmaster58
Copy link

Mattwmaster58 commented Mar 19, 2021

Relatively recently started having this issues as well. Firefox 88

After trying the to enable the permission as suggested by @uberactivist everything works again

@ajayyy
Copy link
Owner

ajayyy commented Mar 20, 2021

@OlgaForoga Yea, the server is broken right now, but feel free to post again if it is still not working one it is fixed

@ajayyy
Copy link
Owner

ajayyy commented Mar 24, 2021

I think this is caused by #698

@Deliphin
Copy link

The force channel check is not the cause. It may be a cause for some people, but on my machine it has no effect.
Force Channel Check ON, Permissions Fix = Skipping works.
Force Channel Check ON, No Perm Fix = Skipping doesn't work.

@AntiSol
Copy link
Author

AntiSol commented May 11, 2021

it looks like #738 solves this for me. I just got a prompt to accept permissions and now it seems that sponsorblock is working again! I've watched a couple of videos and seen skipping work for each.

I've missed it so much! Thanks! :)

@ajayyy
Copy link
Owner

ajayyy commented May 11, 2021

Perfect! Thanks for letting me know

@ajayyy ajayyy closed this as completed May 11, 2021
@LivingFray
Copy link

Not sure that fixed it, I got the prompt clicked it, reloaded the page and got the prompt again

@ajayyy
Copy link
Owner

ajayyy commented May 12, 2021

#741

@ajayyy ajayyy unpinned this issue May 16, 2021
ajayyy added a commit that referenced this issue May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests