Don't call img.onload() manually during test as images might've already loaded #5331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
One of the
a-assets
tests waits for an image to be loaded, but then proceeds to manually invokeimg.onload()
. With the change made in #5253 it's possible that thisonload
isn't defined, causing the test to fail. This seems to happen consistently with Firefox 115, but not on Chrome or older Firefox versions.There is actually no need for the test to call
onload
. It might've been done in an attempt to speed the loading up(?), but that partially invalidates the test, not to mention that other tests do wait on the underlying assets to load naturally.Fixes #5095
Changes proposed:
img.onload()
, but instead rely on the actual loading mechanism (either short-circuiting if already completed oronload
)