Use generic hot key combo for client control #1375

To be able to debug exactly what is wrong with the layout. Unfortunately we don't know what log level is used for actual "invalid layout" message, or if it is even logged as all, since that happens elsewhere. So let's be cautious and use a debug log level here.

This is a general thing so move it in to the core library instead, letting vncviewer focus on just translation of system events to VNC ones.

Encapsulate all the platform specific magic around keyboard in to specific classes, in order to keep the core code more readable.

This make sure we have any new defines, in case we want to use them.

This is mainly a copy of XKeysymToString() from libX11. We've also added a wrapper that still gives a string, even if there is no name for the requested keysym. This grows the binaries a bit, but not with any extreme amount so is hopefully worth it to get better debug logging.

The fake ones have a special mode, so we can simply filter them before they are passed on as FLTK events.

We want to be able to define more keyboard combinations that allows the user to control the client instead of sending the keys to the server. Instead of adding a never ending stream of random keys that just confuses things, we'll define a set of modifiers that are the base for all client control commands.

Allows you to quickly enter and leave full-screen mode.

No matter how carefully you choose your hot key modifiers, there might still be situations where you need to send those hot key combinations to the server instead. This commit adds a method for this by letting the <hotkeys>+Space combination temporarily bypass the hot key logic and send everything to the server (until all keys are released again).

Allows you to grab the keyboard input from the desktop environment even in windowed mode.

We want to show tips for more things, so rework the overlay infrastructure so it can handle an arbitrary amount of messages.

These modes can be non-obvious for users how to get out of, so show an overlay with how to get back to normal when these modes are enabled.

It can get a bit annoying if you keep getting these constantly, so only show them again if enough time has passed since we last showed them.

Let's add an ellipsis if we have to crop the title. Also reduce the maximum length to something reasonable. We want to do the cropping, not let the window manager do it, as otherwise "TigerVNC" might get cropped.

Provide some UI feedback that the keyboard is currently grabbed and local input is prevented.

Make this less complex by removing the timer and retrying things synchronously. This can freeze the UI, but we give up after half a second so it should hopefully not be noticable. The advantage is that we can directly determine if we succeeded or failed grabbing the keyboard. The previous code could in theory continue retrying forever.

It is now very likely that this happens as we will not have permission to do this by default on macOS. So present a message to the user so they understand why the keyboard isn't working as expected.

The system steals keyboard events for certain system keyboard shortcuts, e.g. Cmd+Tab. Unfortunately this isn't considered a focus loss, so we don't realise we've lost a few keyboard events and can end up in a confused state. Fortunately it is possible to detect when this happens and reset the keyboard state, just like we do when focus is lost.

These are the slightly more proper way to grab the keyboard and macOS and is what similar applications do. It avoids a lot of issues we have, e.g., problems with multiple monitors. Unfortunately we need to have the user explicitly approve this (which really is a good thing, security wise), and Apple have chosen to mark this feature as only for accessibility.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use generic hot key combo for client control #1375

Use generic hot key combo for client control #1375

Commits on Oct 14, 2022

Use generic hot key combo for client control #1375

Are you sure you want to change the base?

Use generic hot key combo for client control #1375

Commits on Oct 14, 2022