Code improvements #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The @SuppressWarnings("PatternValidation") annotation was removed from the getName method as it is no longer needed. This change will help maintain cleaner and more readable code without affecting functionality.
Introduced EnumArgumentType class to support enum type argument parsing. Updated AreaFlagCommand to utilize EnumArgumentType for WeatherType enum, enhancing command flexibility.
Updated the FlagArgumentType constructor to apply the provided filter when retrieving flags from the registry. This ensures only the flags that match the filter criteria are considered, improving the flexibility and robustness of the flag processing logic.
Changing the event from WorldLoadEvent to WorldInitEvent ensures areas are loaded earlier in the world lifecycle. This prevents issues arising from accessing not fully initialized worlds in the ProtectPlugin.
Updated the `AreaInfoCommand` to support fetching area information based on command sender's location. Refactored the command execution logic to streamline processing of both explicit and implicit area queries.
Replaced the SLF4JLogger with ComponentLogger for logging warnings about duplicate areas. This enhances the consistency and integration of logging within the existing system.
The line initializing each flag to its default value during deserialization has been removed. This change streamlines the deserialization process and prevents redundant operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change world load to init event to prevent no area found error
Add weather argument type for flags
Made area argument in /area info optional
don't serialize default flags