-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add config.nims
with nim defaults & chore tasks
#21
Conversation
config.nims
with nim defaults & test taskconfig.nims
with nim defaults & chore tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from being cross-platform, I prefer Nimscript configuration file that does not need additional dependency like Nimble or Atlas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this is fine, but I wonder how I will merge it with Github actions from previous PRs. I need to ponder about it a bit.
Two ways:
|
@ZoomRmc The benefits are clear - I fully support your idea. Regarding |
Thanks.
Works on my end. It's rather silent, though. Did you reset your working tree to main? It should make the changes in the dynamic_programming dir. |
I have introduced some incorrect formatting and it was not fixed. I have nimpretty 0.2 and Nim Compiler Version 1.6.12 [Linux: amd64]. |
Co-authored-by: dlesnoff <[email protected]>
Well did the nimpretty run or not with |
It worked well on my end |
Now I could check it again: it turned out that introducing some big number of empty lines is not considered as incorrect format - sorry for the confusion, it works well. |
@ZoomRmc I am having another issue. When running the command Same happens for When I do not use |
@vil02 good catch, thanks. That's a compiler error, it's fixed on devel (not yet sure at which point though). For mitigation we can move the |
This PR adds a
config.nims
that provides:nim_test.yml
#20) .test
to run all the units in the repo as executables, with an assumption it runs tests. Task runs withnim test
.This task is a proposed replacement for the shell scripts from PR chore: add
nim_test.yml
#20.Main benefits over Bash: cross-platform, no additional dependencies.
prettyfy
ro runnimpretty
on all *.nim files in the repository. Task runs withnim prettyfy
This task is a proposed replacement for the shell script from PR chore: add
check_code_format
workflow #19.List of compiler defaults: