chore: add check_code_format workflow
#19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am on a rush, I will test it during the week-end. I made a lot of spaces on empty lines :( Very nice first contribution. I guess this fixes issue #16 . |
Panquesito7
requested changes
May 31, 2023
Nimpretty, as far as I can tell, is a code formatter - it does not perform any static analysis. |
|
@Panquesito7 Now the workflow fails if there are some It works on my side: I hope you were not floated by e-mails with every commit - I have forgotten to change it to a draft. |
vil02
changed the title
run_nimpretty workflowrun_nimpretty workflow
dlesnoff
requested changes
Jun 1, 2023
|
I propose replacing the bash script with a task from #21. |
vil02
changed the title
run_nimpretty workflowcheck_code_format workflow
dlesnoff
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a workflow running the command
nim prettyfyon the entire project.The added workflow is executed on every push to master and pull reques
It turned out, that there are already two files, which are not correctly formatted: c6acd82.
The shell script could be removed thanks to #21.