Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add radixsort implementation #42

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AmanxUpadhyay
Copy link

This pull request introduces an in-place Radix Sort algorithm implementation in the sort/radixsort.jule file. The key changes include the addition of the CountingSort and RadixSort functions, as well as an example usage in the main function.

New features:

  • sort/radixsort.jule: Added CountingSort function to perform counting sort based on the digit represented by exp.
  • sort/radixsort.jule: Added RadixSort function to sort an array of integers using the Radix Sort algorithm.
  • sort/radixsort.jule: Included an example usage of RadixSort in the main function, demonstrating the sorting of an array and printing the sorted result.

Copy link
Member

@mertcandav mertcandav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The counting sort is already exists in the sort package, the Count function. Please use existing functions. Do not write the main function, just write tests for your implementations. If exists, use common test cases.

As I said in the PR #41, your code should be correct syntactically and semantically. But this codes won't compile because of invalid syntaxes and semantic problems. Please test your code in your machine and fix the compilation problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants