Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Issue #5613- Snake and Ladder Game Minimum Dice Throws Required #5765

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

sherlockwayne
Copy link

@sherlockwayne sherlockwayne commented Oct 13, 2024

PR for issue #5613

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 43 lines in your changes missing coverage. Please review.

Project coverage is 63.98%. Comparing base (ebc3cd2) to head (89fc5bd).

Files with missing lines Patch % Lines
.../java/com/thealgorithms/others/SnakeAndLadder.java 0.00% 43 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5765      +/-   ##
============================================
- Coverage     64.13%   63.98%   -0.16%     
  Complexity     4205     4205              
============================================
  Files           587      588       +1     
  Lines         16388    16431      +43     
  Branches       3163     3172       +9     
============================================
+ Hits          10511    10513       +2     
- Misses         5448     5490      +42     
+ Partials        429      428       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sherlockwayne sherlockwayne changed the title snake and ladder problem Issue #5613: Snake and Ladder Game Minimum Dice Throws Required Oct 13, 2024
@sherlockwayne sherlockwayne changed the title Issue #5613: Snake and Ladder Game Minimum Dice Throws Required feat:Issue #5613- Snake and Ladder Game Minimum Dice Throws Required Oct 13, 2024
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove main and add JUnit tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants