Update 0_1_knapsack.cpp #2852
Open
Update 0_1_knapsack.cpp #2852
+0
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(knapsack): correct array size calculation and test case simplification - Removed incorrect size calculation using sizeof and replaced it with std::array's size method. - Simplified test cases by directly using the array size as inferred by std::array. - Updated comments for clarity and code readability. - Ensured correct logic flow for 0-1 Knapsack dynamic programming solution. This commit fixes logical errors in the array size handling and makes the code more robust and easy to maintain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(knapsack): correct array size calculation and test case simplification
This commit fixes logical errors in the array size handling and makes the code more robust and easy to maintain.
Description of Change
Checklist
Notes: