docs, test: Fit Topological Sort algorithm to contributing guidelines #2835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarshilShah1804
requested review from
Panquesito7 and
realstealthninja
as code owners
realstealthninja
requested changes
Oct 14, 2024
| graph::addEdge(adj_1, 3, 1); | ||
| graph::addEdge(adj_1, 4, 1); | ||
| std::vector<int> ans_1 = graph::topological_sort(adj_1, n_1); | ||
| std::vector<int> expected_1 = {5, 4, 2, 3, 1, 0}; |
There was a problem hiding this comment.
should try using std::is_sorted if possible
There was a problem hiding this comment.
@realstealthninja Can you please brief me what should I do using std::is_sorted as the topological sort of a graph is not necessary in sorted order of numbers. It depends on how edges are present in the directed graph.
Thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Added namespaces and updated existing documentation and tests to fit current guidelines
Checklist
Notes: