Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Binary Addition Algorithm #2802

Open
wants to merge 42 commits into
base: master
Choose a base branch
from

Conversation

mjk22071998
Copy link
Contributor

@mjk22071998 mjk22071998 commented Oct 9, 2024

Description of Change

I have added Binary addition algorithm that takes two binary numbers as string and return a string containing a binary number equals to sum of above two numbers. This PR is under hacktoberfest

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

mjk22071998 and others added 30 commits October 5, 2024 10:13
…d data types to std::int64_t, and reformatted code."
Co-authored-by: realstealthninja <[email protected]>
Co-authored-by: realstealthninja <[email protected]>
@realstealthninja realstealthninja added the awaiting modification Do not merge until modifications are made label Oct 10, 2024
}

/**
* Main function to execute the program.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Main function to execute the program.
* @brief main function
* @return 0 on successful exit

* Main function to execute the program.
*/
int main() {
tests();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tests();
tests(); // run self test implementation

*/
namespace greedy_algorithms {
/**
* A class to perform binary addition of two binary strings.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please document functions and classes according to the contributing.md file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting modification Do not merge until modifications are made
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants