Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of Non-preemptive SJF scheduling #2801

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Implementation of Non-preemptive SJF scheduling #2801

wants to merge 22 commits into from

Conversation

LakshmiSrikumar
Copy link

@LakshmiSrikumar LakshmiSrikumar commented Oct 9, 2024 •
edited
Loading

Description of Change

Non pre-emptive SJF Scheduling algorithm
Added C++ implementation of SJF scheduling algorithm in the directory cpu_scheduling/

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@realstealthninja
Copy link
Collaborator

  1. put it in some directory instead of the root directory.
  2. you haven't checked any of the checkboxes in your pull request
  3. please add a description to the pr

@realstealthninja realstealthninja added invalid awaiting modification Do not merge until modifications are made labels Oct 9, 2024
@realstealthninja
Copy link
Collaborator

https://github.com/TheAlgorithms/C-Plus-Plus/blob/master/CONTRIBUTING.md#Commit-Guidelines
read this contributing file thank you!

@LakshmiSrikumar
Copy link
Author

@realstealthninja I have done the following

@LakshmiSrikumar
Copy link
Author

@realstealthninja Could you please review the PR ? And could the hacktober label be put ?

realstealthninja
realstealthninja requested changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this algorithm to cpu_scheduling/ since that seems appropriate

non_preemptive_sjf_scheduling.cpp Outdated Show resolved Hide resolved
non_preemptive_sjf_scheduling.cpp Outdated Show resolved Hide resolved
non_preemptive_sjf_scheduling.cpp Outdated Show resolved Hide resolved
non_preemptive_sjf_scheduling.cpp Outdated Show resolved Hide resolved
non_preemptive_sjf_scheduling.cpp Outdated Show resolved Hide resolved
non_preemptive_sjf_scheduling.cpp Outdated Show resolved Hide resolved
realstealthninja
realstealthninja requested changes Oct 11, 2024
View reviewed changes
non_preemptive_sjf_scheduling.cpp Outdated Show resolved Hide resolved
non_preemptive_sjf_scheduling.cpp Outdated Show resolved Hide resolved
@LakshmiSrikumar
Create non_preemptive_sjf_scheduling.cpp
9d9b51f 
I have done the necessary changes.
The test function will generate 10 different testcases in which it will print  the before and after the SJF scheduling.

@realstealthninja Kindly review the PR and please accept it.
@LakshmiSrikumar
Merge branch 'LakshmiSrikumar-patch-1' of https://github.com/LakshmiS…
f1338b0 
…rikumar/C-Plus-Plus into LakshmiSrikumar-patch-1
@LakshmiSrikumar
Delete non_preemptive_sjf_scheduling.cpp
4404bbb
@LakshmiSrikumar
Copy link
Author

I have done the necessary changes.

  1. changed the file directory to /cpu_scheduling_algorithms
  2. Now, the test function will generate 10 different testcases in which it will print the before and after the SJF scheduling for each test case.

@realstealthninja Kindly review the PR and please accept it.

@LakshmiSrikumar
Copy link
Author

@realstealthninja could you please approve the repo ?

realstealthninja
realstealthninja approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@LakshmiSrikumar
Copy link
Author

The approved label is not added

@LakshmiSrikumar
Copy link
Author

LakshmiSrikumar commented Oct 17, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realstealthninja realstealthninja realstealthninja approved these changes

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7 Panquesito7 is a code owner

Assignees
No one assigned
Labels
awaiting modification Do not merge until modifications are made hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LakshmiSrikumar @realstealthninja