Job sequencing algorithm explanation & implementation added. #2797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maahmoudezzat
requested review from
Panquesito7 and
realstealthninja
as code owners
realstealthninja
requested changes
Oct 9, 2024
There was a problem hiding this comment.
Thank you for contributing. This has a very nicely written header.
Please do read the contributing.md file and fix the documentation issues with the functions, headers. Please also add tests n a separate function
realstealthninja
added
awaiting modification
Co-authored-by: realstealthninja <[email protected]>
Co-authored-by: realstealthninja <[email protected]>
Co-authored-by: realstealthninja <[email protected]>
Co-authored-by: realstealthninja <[email protected]>
|
Thanks for the review.
|
realstealthninja
requested changes
Oct 10, 2024
Co-authored-by: realstealthninja <[email protected]>
Co-authored-by: realstealthninja <[email protected]>
Co-authored-by: realstealthninja <[email protected]>
realstealthninja
requested changes
Oct 12, 2024
Co-authored-by: realstealthninja <[email protected]>
Co-authored-by: realstealthninja <[email protected]>
|
@realstealthninja Hey, I'm waiting for your reveiw. |
realstealthninja
requested changes
Oct 15, 2024
| @@ -85,7 +85,6 @@ | |||
| "xstring": "cpp", | |||
There was a problem hiding this comment.
remove changes to this file
| * | ||
| * @param arr array fo Jobs | ||
| * @param n number of the jobs in the array | ||
| * @returns vector of 'char' including the IDs of jobs |
There was a problem hiding this comment.
template parameter N should be documented
@ tparam N <describe N>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Checklist
A well-formatted and organized Job sequencing algorithm explanation & implementation added applying a greedy approach using the priority_queue data structure.
Notes: