Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs, test: fit modular inverse fermat little theorem to contributing guidelines #2779

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

docs, test: fit modular inverse fermat little theorem to contributing guidelines #2779

wants to merge 15 commits into from

Conversation

hollowcrust
Copy link
Contributor

@hollowcrust hollowcrust commented Oct 7, 2024 •
edited
Loading

Description of Change

Reformat math/modular_inverse_fermat_little_theorem.cpp by adding namespaces, documentations, tests.

Checklist

  • Added description of change
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:
For Hacktoberfest, for #2456

@realstealthninja realstealthninja changed the title docs, test: Add documentations and tests for modular_inverse_fermat_little_theorem.cpp docs, test: fit modular inverse fermant little theorem to contributing guidelines Oct 7, 2024
@realstealthninja realstealthninja added the awaiting modification Do not merge until modifications are made label Oct 7, 2024
@hollowcrust hollowcrust changed the title docs, test: fit modular inverse fermant little theorem to contributing guidelines docs, test: fit modular inverse fermat little theorem to contributing guidelines Oct 8, 2024
@hollowcrust
Copy link
Contributor Author

@realstealthninja Hi can you help me review please?

@hollowcrust hollowcrust mentioned this pull request Oct 10, 2024
Merged
7 tasks
realstealthninja
realstealthninja approved these changes Oct 12, 2024
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@realstealthninja realstealthninja added approved Approved; waiting for merge hacktoberfest-accepted Accepted to be counted towards Hacktoberfest and removed awaiting modification Do not merge until modifications are made labels Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realstealthninja realstealthninja realstealthninja approved these changes

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7 Panquesito7 is a code owner

Assignees
No one assigned
Labels
approved Approved; waiting for merge hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hollowcrust @realstealthninja