-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shopify Liquid VS Code extension for Web #529
base: main
Are you sure you want to change the base?
Commits on Oct 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d1ad293 - Browse repository at this point
Copy the full SHA d1ad293View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ae71e3 - Browse repository at this point
Copy the full SHA 8ae71e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 253983d - Browse repository at this point
Copy the full SHA 253983dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d7cefe - Browse repository at this point
Copy the full SHA 4d7cefeView commit details
Commits on Oct 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9feef3b - Browse repository at this point
Copy the full SHA 9feef3bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ee1903 - Browse repository at this point
Copy the full SHA 3ee1903View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54b290e - Browse repository at this point
Copy the full SHA 54b290eView commit details
Commits on Oct 15, 2024
-
Replace
fileExists
dependency byfs
injection- Change `Config` interface to refer to `rootUri` instead of `root` as an absolutePath - Get rid of `fileExists` DI in theme-check Dependencies - Get rid of `fileExists` DI in theme-language-server Dependencies - Add `fs` DI in theme-check Dependencies - Add `fs` DI in theme-language-server Dependencies - Add `MockFileSystem` implementation (for tests) - Add `NodeFileSystem` implementation - Add optional `fs` argument to `theme-language-server-node#startServer()` The `fs` DI has the following interface (so far): ```ts interface FileSystem { stat(uri: string): Promise<{ fileType, size }>; readFile(uri: string): Promise<string>; readDirectory(uri: string): Promise<[uri: string, fileType: FileType][]>; } ``` theme-language-server-node now also accepts an optional `fs` implementation in startServer.
Configuration menu - View commit details
-
Copy full SHA for d7088a0 - Browse repository at this point
Copy the full SHA d7088a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for f0e085c - Browse repository at this point
Copy the full SHA f0e085cView commit details -
Replace getDefault(Schema)?Locale dependency injection
Instead of having that logic be injected in, I added an abstract implementation in theme-check-common that depends on the virtual file system. We will no longer need to inject this behaviour :)
Configuration menu - View commit details
-
Copy full SHA for 74eddea - Browse repository at this point
Copy the full SHA 74eddeaView commit details -
Rename FileSystem to AbstractFileSystem
FileSystem is an ambient import which made the DX suffer when refactoring code. It's also more obvious now that the FileSystem interface is an interface that you need to implement, not something concrete that you can use directly.
Configuration menu - View commit details
-
Copy full SHA for 35ff79e - Browse repository at this point
Copy the full SHA 35ff79eView commit details -
Replace AbsolutePath concern in theme-check-common
Replace it with URIs. That way we won't need to worry about windows paths being weird. The only place where we still have them is for places where we deal with `glob` and `loadConfig` in `theme-{check,language-server}-node`. - SourceCode.absolutePath -> SourceCode.uri - etc.
Configuration menu - View commit details
-
Copy full SHA for 837440d - Browse repository at this point
Copy the full SHA 837440dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e4bf7d - Browse repository at this point
Copy the full SHA 2e4bf7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 35b07d1 - Browse repository at this point
Copy the full SHA 35b07d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 28dfbe8 - Browse repository at this point
Copy the full SHA 28dfbe8View commit details
Commits on Oct 16, 2024
-
Remove getDefault(Schema)?Translations dependencies
We still have an optiomal dependency that is otherwise implemented by a naive implementation (for CLI use cases), but in the language server we prefer the buffer over the file in the file system... Which makes me think we could get rid of that by actually making that logic part of the getTranslationsFactory directly. Prefer theme files over fs.
Configuration menu - View commit details
-
Copy full SHA for dab4b58 - Browse repository at this point
Copy the full SHA dab4b58View commit details -
Move buffer translations concern to theme-check-common
All that logic didn't need to be in the language server. This makes the dep injection easier too because we no longer have this upstream concern.
Configuration menu - View commit details
-
Copy full SHA for c0980f9 - Browse repository at this point
Copy the full SHA c0980f9View commit details -
Remove filesForURI language server dependency
Replace with AbstractFileSystem-based implementation
Configuration menu - View commit details
-
Copy full SHA for 6f6db6b - Browse repository at this point
Copy the full SHA 6f6db6bView commit details -
Remove getThemeSettingsSchemaForURI injection
Replace with abstract-file-system-based implementation TODO make that shit faster. Seems highlighy unoptimized.
Configuration menu - View commit details
-
Copy full SHA for 6ec9236 - Browse repository at this point
Copy the full SHA 6ec9236View commit details -
Replace with abstract-file-system-based implementation in common code.
Configuration menu - View commit details
-
Copy full SHA for a501a10 - Browse repository at this point
Copy the full SHA a501a10View commit details -
Implement and setup basic VsCodeFileSystem
- Adds support for VS Code for Web - Adds support for remote files
Configuration menu - View commit details
-
Copy full SHA for 71d5086 - Browse repository at this point
Copy the full SHA 71d5086View commit details
Commits on Oct 17, 2024
-
Optimize FS calls in the Language Server
You don't need to query VS Code _every time_ the user types something for the same imformation. That's rather slow! We'll invalidate the relevant caches when files are saved/deleted/created/renamed.
Configuration menu - View commit details
-
Copy full SHA for a15e42c - Browse repository at this point
Copy the full SHA a15e42cView commit details -
Implement MainThreadFileSystem in CodeMirror Playground
Made to demo what it's like to use a VirtualFileSystem in a non-vscode environment.
Configuration menu - View commit details
-
Copy full SHA for 01e1f06 - Browse repository at this point
Copy the full SHA 01e1f06View commit details -
Configuration menu - View commit details
-
Copy full SHA for f3d1197 - Browse repository at this point
Copy the full SHA f3d1197View commit details
Commits on Oct 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3a7ea94 - Browse repository at this point
Copy the full SHA 3a7ea94View commit details -
Configuration menu - View commit details
-
Copy full SHA for d87c592 - Browse repository at this point
Copy the full SHA d87c592View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a58241 - Browse repository at this point
Copy the full SHA 0a58241View commit details