Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust: fix ICE during name resolution for impls on unit-types #3177

Merged
merged 1 commit into from
Sep 27, 2024
Merged

rust: fix ICE during name resolution for impls on unit-types #3177

merged 1 commit into from
Sep 27, 2024

Commits on Sep 27, 2024

  1. rust: fix ICE during name resolution for impls on unit-types 

    The canonical paths need to support unit-types which are technically a
TupleType with no fields. This handles this case and adds an unreachable.

Fixes #3036

gcc/rust/ChangeLog:

	* resolve/rust-ast-resolve-type.cc (ResolveTypeToCanonicalPath::visit): add unit-type catch
	* resolve/rust-ast-resolve-type.h: likewise

gcc/testsuite/ChangeLog:

	* rust/compile/nr2/exclude: nr2 cant handle this
	* rust/compile/issue-3036.rs: New test.

Signed-off-by: Philip Herron <[email protected]>
    @philberty
    philberty committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    a72f69f View commit details
    Browse the repository at this point in the history