Skip to content

Commit

Permalink
Use name resolver 2.0 in const checker
Browse files Browse the repository at this point in the history
gcc/rust/ChangeLog:

	* checks/errors/rust-const-checker.cc: Add includes.
	(ConstChecker::visit): Use name resolver 2.0 to lookup
	function definitions when name resolution 2.0 is enabled.

gcc/testsuite/ChangeLog:

	* rust/compile/nr2/exclude: Remove entries.

Signed-off-by: Owen Avery <[email protected]>
  • Loading branch information
powerboat9 committed Oct 17, 2024
1 parent 20ef282 commit 73c1ddd
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 4 deletions.
16 changes: 15 additions & 1 deletion gcc/rust/checks/errors/rust-const-checker.cc
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@
#include "rust-hir-stmt.h"
#include "rust-hir-item.h"
#include "rust-system.h"
#include "rust-immutable-name-resolution-context.h"

// for flag_name_resolution_2_0
#include "options.h"

namespace Rust {
namespace HIR {
Expand Down Expand Up @@ -354,8 +358,18 @@ ConstChecker::visit (CallExpr &expr)
NodeId ast_node_id = expr.get_fnexpr ()->get_mappings ().get_nodeid ();
NodeId ref_node_id;

if (flag_name_resolution_2_0)
{
auto &nr_ctx
= Resolver2_0::ImmutableNameResolutionContext::get ().resolver ();

if (auto id = nr_ctx.lookup (ast_node_id))
ref_node_id = *id;
else
return;
}
// We don't care about types here
if (!resolver.lookup_resolved_name (ast_node_id, &ref_node_id))
else if (!resolver.lookup_resolved_name (ast_node_id, &ref_node_id))
return;

if (auto definition_id = mappings.lookup_node_to_hir (ref_node_id))
Expand Down
3 changes: 0 additions & 3 deletions gcc/testsuite/rust/compile/nr2/exclude
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@ closure_no_type_anno.rs
complex-path1.rs
complex_qualified_path_in_expr.rs
const-issue1440.rs
const1.rs
const3.rs
const_generics_3.rs
const_generics_4.rs
const_generics_5.rs
Expand All @@ -38,7 +36,6 @@ derive_macro1.rs
derive_macro3.rs
derive_macro4.rs
derive_macro6.rs
diagnostic_underline.rs
expected_type_args2.rs
expected_type_args3.rs
feature_rust_attri0.rs
Expand Down

0 comments on commit 73c1ddd

Please sign in to comment.