#3 Implement string fakeit #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-murph37
changed the title
|
Thanks for the PR @the-murph37, hope you enjoy playing with Rust :) Yes I'm on holiday at the moment, but I will review it ASAP. |
PumpkinSeed
requested changes
Sep 23, 2023
| @@ -0,0 +1,171 @@ | |||
| use rand::seq::SliceRandom; | |||
There was a problem hiding this comment.
You shouldn't use rand package because the whole package using simplerand. It is because the rand package is an overkill for this library. Also if you are using rand package and I add the custom seed value functionality to the code-base (one of the requested feature), it won't work for string functions, because it will use the rand package's seed value.
Please use simplerand, or write a wrapper/helper function for that in the misc.rs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@PumpkinSeed, attempting to learn Rust along with @bbejot. I saw in his PR that you are away for a bit, so feel free to get back to me whenever you're available.
Used the string.go file to try and head in the right direction. This is my first foray into Rust, so feel free to rip it apart.