Don't run player loot table for spectators #11464
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Machine-Maker
added
the
build-pr-jar
|
I test and experience its not dropped in spectator mode but this is because the "keepLevel" behaviour use the same logic for keep is the keep inventory is true or the player is in spectator. also the "logic" for get how many exp need to be dropped is 0 for spectator but not sure from where comes that.. i just found a call for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there's also an issue with spectators and xp dropping, but I can't test that out right now. Until I check that, this can be a draft.
Fixes #11463
Download the paperclip jar for this pull request: paper-11464.zip