feat: introduce $ouds-border-radius-9999 raw token and create a px-to-rem Sass function
#2751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
julien-deramond
force-pushed
the
main-jd-reintegrate-border-radius-9999
branch
from
df3ed04
to
df0aca9
Compare
…-to-rem` function
julien-deramond
force-pushed
the
main-jd-reintegrate-border-radius-9999
branch
from
df0aca9
to
f5a2c44
Compare
louismaximepiton
changed the title
raw token and create a px-to-rem` Sass function$ouds-border-radius-9999 raw token and create a px-to-rem Sass function
julien-deramond
commented
Oct 3, 2024
vprothais
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We finally decided to (re)introduce
$ouds-border-radius-9999that comes from Figma.This value is set to
2000pxso we needed to transform it to125rem. Hence, the creation of a newpx-to-remSass function, that will be useful for other use cases in the future.Live previews