DIMAP: for PNEO products, use the new color interpretations for the NIR, RedEdge and DeepBlue/Coastal bands #11043
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @tbonfort
In b3f3ce7 , you added logic to register metadata on the bands, but it doesn't look to work with the fake dataset we have in autotest/gdrivers/data/dimap2/vhr2020_ms_fs/MS-FS/DIM_MS-FS.XML, nor a PNEO_ORTHO_BUNDLE-FS_REFLECTANCE_JPEG2000_4326_NONE_STD_A one I likely got during the development of the PNEO support.
The reason I ask is that I rather see a Radiometric_Data.Radiometric_Calibration.Band_Spectral_Range (rather than Radiometric_Data.Radiometric_Calibration.Instrument_Calibration.Band_Measurement_List as expected by the driver) element with subnodes like:
I guess we could take the mean of FWHM.MIN and .MAX as the central wavelength, and MAX-MIN as the FWHM value to report in the new IMAGERY band metadata domain (cf https://gdal.org/en/latest/user/raster_data_model.html#imagery-domain-remote-sensing)