Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIMAP: for PNEO products, use the new color interpretations for the NIR, RedEdge and DeepBlue/Coastal bands #11043

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rouault
Copy link
Member

@rouault rouault commented Oct 17, 2024

CC @tbonfort

In b3f3ce7 , you added logic to register metadata on the bands, but it doesn't look to work with the fake dataset we have in autotest/gdrivers/data/dimap2/vhr2020_ms_fs/MS-FS/DIM_MS-FS.XML, nor a PNEO_ORTHO_BUNDLE-FS_REFLECTANCE_JPEG2000_4326_NONE_STD_A one I likely got during the development of the PNEO support.
The reason I ask is that I rather see a Radiometric_Data.Radiometric_Calibration.Band_Spectral_Range (rather than Radiometric_Data.Radiometric_Calibration.Instrument_Calibration.Band_Measurement_List as expected by the driver) element with subnodes like:

                        <Band_Spectral_Range>
                                <BAND_ID>R</BAND_ID>
                                <CALIBRATION_DATE>2019-05-20T09:07:00Z</CALIBRATION_DATE>
                                <MEASURE_DESC>Spectral Range values of raw radiometric Band</MEASURE_DESC>
                                <MEASURE_UNIT>micrometer</MEASURE_UNIT>
                                <MEASURE_UNCERTAINTY>0</MEASURE_UNCERTAINTY>
                                <FWHM>
                                        <MIN>0.619</MIN>
                                        <MAX>0.69</MAX>
                                </FWHM>
                                <GAIN>0</GAIN>
                                <BIAS>0</BIAS>
                        </Band_Spectral_Range>

I guess we could take the mean of FWHM.MIN and .MAX as the central wavelength, and MAX-MIN as the FWHM value to report in the new IMAGERY band metadata domain (cf https://gdal.org/en/latest/user/raster_data_model.html#imagery-domain-remote-sensing)

@rouault rouault added the backport release/3.10 Backport to release/3.10 branch label Oct 17, 2024
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 69.45% (+0.005%) from 69.445%
when pulling 79b446f on rouault:DIMAP_PNEO_GCI
into c044df7 on OSGeo:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release/3.10 Backport to release/3.10 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants