Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON TileMatrixSet parser: accept crs.uri and crs.wkt encodings #10990

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

rouault
Copy link
Member

@rouault rouault commented Oct 11, 2024

Fixes #10989

@rouault rouault added this to the 3.10.0 milestone Oct 11, 2024
@jratike80
Copy link
Collaborator

I understood from the standard that the wkt option means a projjson string.

@rouault
Copy link
Member Author

rouault commented Oct 11, 2024

I understood from the standard that the wkt option means a projjson string.

yeah, that's highly confusing, and I suppose in high flux given how uncertain PROJJSON future is at OGC, given they are likely to fork it in a backwards incompatible way to create a OGC CRSJSON: https://github.com/opengeospatial/CRS-JSON-Encoding
In any case, be it WKT or PROJJSON, this will work with this PR as this is passed downstream to OGRSpatialReference::SetFromUserInput() which accepts both.

@jratike80
Copy link
Collaborator

Ok, good. The standard anticipates the future:

NOTE This Standard adopts the https://proj.org/specifications/projjson.html encoding, pending a resolution in the CRS group for adopting a possible future JSON encoding for WKT for CRS 2.0

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 69.445% (-0.001%) from 69.446%
when pulling b979373 on rouault:fix_10989
into 6cf71ee on OSGeo:master.

@rouault rouault merged commit d8112b7 into OSGeo:master Oct 15, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse ogcapi TileMatrixSet crs object
3 participants