starting to add testing for I/O subroutine W3IOPO() so it can be converted to use netCDF #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@edwardhartnett the PR that also updated w3iopo was just merged as an FYI |
|
@JessicaMeixner-NOAA what I need to do in test_io.F90 is set up all the module variables needed for a data write to take place. In other words, I need everything to be ready so that w3iopo() can be called and successfully write data. Can you guys help me do that? |
|
@edwardhartnett - @MatthewMasarik-NOAA and I can help. However, perhaps instead of setting up a completely separate testing system we can leverage an existing regression test instead? |
|
I'm not sure what you mean by regression test. Do you mean some manual testing? I mean a test which runs in the CI system. Can any of your regression tests run with CI? |
|
The CI system only runs builds. There are no plans to expand the CI testing at this time due to higher priority issues related to operational implementations. |
|
Can you tell me where the regressions tests are and how to build and run them? |
|
@edwardhartnett, yes, sure thing. I'm tied up right now till ~11:15. I'll reach out after that. |
edwardhartnett
changed the title
|
See the canned example on hera: /scratch1/NCEPDEV/climate/Matthew.Masarik/waves/share/point_output |
|
OK, I got Matt's "canned case" to run on my linux machine with GNU compilers. Here's how it works: Basically I just had to comment out all the module commands, and change Intel to GNU compilers in build_ww3, and have my spack env activated so all the dependencies can be found. Then I ran run_ww3.sh and it failed do to lack of slurm, but it did succeed in copying all necessary files to directory /home/ed/ww3-test-case/work_909127, and when I cd to this directory and do: ./ww3_shel I get the following output: and the subdirectory contains a file out_pnt.ww3, which is the binary format point data. The swich file is in the parent directory and contains: NOGRB SHRD PR1 FLX2 LN0 ST0 NL0 BT0 DB0 TR0 BS0 IC0 IS0 REF0 WNT1 WNX1 CRT1 CRX1 O0 O1 O2 O3 O4 O5 O6 O7 O10 O11 |
variable documentation
|
@edwardhartnett I know this is a draft PR, but it also contains binaries that we want to make sure do not get into the WW3 repository so just a quick note here about that as well. |
|
@JessicaMeixner-NOAA yes, I will resolve the binary file issue in the other PR and then update this one with that fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR to engage CI in testing development...
Part of #682