-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type annotation work in manim/mobject/geometry/ #3961
Open
henrikmidtiby
wants to merge
13
commits into
ManimCommunity:main
Choose a base branch
from
henrikmidtiby:type_annotation_work
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Type annotation work in manim/mobject/geometry/ #3961
henrikmidtiby
wants to merge
13
commits into
ManimCommunity:main
from
henrikmidtiby:type_annotation_work
+308
−204
Commits on Oct 17, 2024
-
Removed type annotation errors
The following four errors are removed with the commit. manim/mobject/geometry/labeled.py:63: error: Function is missing a type annotation for one or more arguments [no-untyped-def] manim/mobject/geometry/labeled.py:70: error: Incompatible default for argument "frame_fill_color" (default has type "None", argument has type "ManimColor | int | str | tuple[int, int, int] | tuple[float, float, float] | <6 more items>") [assignment] manim/mobject/geometry/labeled.py:82: error: Incompatible types in assignment (expression has type "MathTex | Text", variable has type "MathTex") [assignment] manim/mobject/geometry/labeled.py:150: error: Function is missing a type annotation for one or more arguments [no-untyped-def]
Configuration menu - View commit details
-
Copy full SHA for 35597d5 - Browse repository at this point
Copy the full SHA 35597d5View commit details -
Removed type annotation errors
The following errors are removed with the commit. manim/mobject/geometry/tips.py:115: error: Function is missing a type annotation for one or more arguments [no-untyped-def] manim/mobject/geometry/tips.py:208: error: Function is missing a type annotation [no-untyped-def] manim/mobject/geometry/tips.py:232: error: Function is missing a return type annotation [no-untyped-def] manim/mobject/geometry/tips.py:245: error: Function is missing a type annotation for one or more arguments [no-untyped-def] manim/mobject/geometry/tips.py:273: error: Function is missing a type annotation for one or more arguments [no-untyped-def] manim/mobject/geometry/tips.py:282: error: Function is missing a type annotation for one or more arguments [no-untyped-def] manim/mobject/geometry/tips.py:301: error: Function is missing a type annotation for one or more arguments [no-untyped-def] manim/mobject/geometry/tips.py:310: error: Function is missing a type annotation for one or more arguments [no-untyped-def] manim/mobject/geometry/tips.py:333: error: Function is missing a type annotation for one or more arguments [no-untyped-def] The following errors are still present: manim/mobject/geometry/tips.py:167: error: Unsupported left operand type for - ("tuple[float, float, float]") [operator] manim/mobject/geometry/tips.py:167: note: Both left and right operands are unions manim/mobject/geometry/tips.py:230: error: Argument 1 to "scale" of "Mobject" has incompatible type "floating[Any]"; expected "float" [arg-type]
Configuration menu - View commit details
-
Copy full SHA for cd73909 - Browse repository at this point
Copy the full SHA cd73909View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ba82f7 - Browse repository at this point
Copy the full SHA 1ba82f7View commit details
Commits on Oct 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3b38bba - Browse repository at this point
Copy the full SHA 3b38bbaView commit details -
Configuration menu - View commit details
-
Copy full SHA for b6f8e38 - Browse repository at this point
Copy the full SHA b6f8e38View commit details -
Avoid overwriting the invert method of the superclass
TypeErrorCount: 1773
Configuration menu - View commit details
-
Copy full SHA for 5bf79dc - Browse repository at this point
Copy the full SHA 5bf79dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 612068d - Browse repository at this point
Copy the full SHA 612068dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 774c136 - Browse repository at this point
Copy the full SHA 774c136View commit details -
Configuration menu - View commit details
-
Copy full SHA for be3938d - Browse repository at this point
Copy the full SHA be3938dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5be34e3 - Browse repository at this point
Copy the full SHA 5be34e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for bbfb247 - Browse repository at this point
Copy the full SHA bbfb247View commit details -
Configuration menu - View commit details
-
Copy full SHA for d294e6f - Browse repository at this point
Copy the full SHA d294e6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 00a0b1f - Browse repository at this point
Copy the full SHA 00a0b1fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.