Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type annotation work in manim/mobject/geometry/ #3961

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Commits on Oct 17, 2024

  1. Removed type annotation errors

    The following four errors are removed with the commit.
    manim/mobject/geometry/labeled.py:63: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
    manim/mobject/geometry/labeled.py:70: error: Incompatible default for argument "frame_fill_color" (default has type "None", argument has type "ManimColor | int | str | tuple[int, int, int] | tuple[float, float, float] | <6 more items>")  [assignment]
    manim/mobject/geometry/labeled.py:82: error: Incompatible types in assignment (expression has type "MathTex | Text", variable has type "MathTex")  [assignment]
    manim/mobject/geometry/labeled.py:150: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
    henrikmidtiby committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    35597d5 View commit details
    Browse the repository at this point in the history
  2. Removed type annotation errors

    The following errors are removed with the commit.
    manim/mobject/geometry/tips.py:115: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
    manim/mobject/geometry/tips.py:208: error: Function is missing a type annotation  [no-untyped-def]
    manim/mobject/geometry/tips.py:232: error: Function is missing a return type annotation  [no-untyped-def]
    manim/mobject/geometry/tips.py:245: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
    manim/mobject/geometry/tips.py:273: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
    manim/mobject/geometry/tips.py:282: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
    manim/mobject/geometry/tips.py:301: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
    manim/mobject/geometry/tips.py:310: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
    manim/mobject/geometry/tips.py:333: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
    
    The following errors are still present:
    manim/mobject/geometry/tips.py:167: error: Unsupported left operand type for - ("tuple[float, float, float]")  [operator]
    manim/mobject/geometry/tips.py:167: note: Both left and right operands are unions
    manim/mobject/geometry/tips.py:230: error: Argument 1 to "scale" of "Mobject" has incompatible type "floating[Any]"; expected "float"  [arg-type]
    henrikmidtiby committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    cd73909 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1ba82f7 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Configuration menu
    Copy the full SHA
    3b38bba View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b6f8e38 View commit details
    Browse the repository at this point in the history
  3. Avoid overwriting the invert method of the superclass

    TypeErrorCount: 1773
    henrikmidtiby committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    5bf79dc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    612068d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    774c136 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    be3938d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5be34e3 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    bbfb247 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    d294e6f View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    00a0b1f View commit details
    Browse the repository at this point in the history