Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Add an option to restore the bomb flower puzzle blocking DRC entrance #392

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Aelire
Copy link
Contributor

@Aelire Aelire commented Jun 14, 2024

Looking for some feedback on whether this would be interesting / considered for inclusion. There are some remaining issues with dungeon-only start explained below that I'm trying to figure out good solutions for, but if this is a no-go in the first place I can spare some work :)

Currently the randomizer removes the puzzle at the entrance to DRC where you have to blow up a boulder to fill up a pond with water to cross a gap. This means that the DRC entrance is always accessible from the very start of the game with no items.
Comments on the patch imply that this was made because the boulder is counter-intuitively only breakable with bomb flowers, rather than the usual bombs or power bracelets.
Replacing this special boulder (Eskban) with a normal one (Ebrock) makes the puzzle much more intuitive, so a few people in the racing community have considered restoring this puzzle with this change to add a bit of variety

Randomisation failures

  • It's possible with this option to craft a seed with enough progression locations in logic but no location accessible from the game start, even without entrance randomizer (eg dungeon-only seed with "Open DRC" unchecked and default starting items).
    This was already possible without this option with dungeonless seeds (eg MS4xMC4wXzZhMzc4ZjgAQQAAIx8AAAj4AuASAAAAAAgABAEAAg==), so I'm not sure if this is considered a regression

  • With entrance randomizer, the "safety entrance" mechanism doesn't take into account starting items, so seeds that could potentially randomize successfully by having enough starting items to open one of the dungeon entrances would fail to randomize
    I'm planning to send a couple additional changes (still wip) to the entrance randomizer to successfully choose a safety entrance more dynamically, reducing (hopefully eliminating) the spurious randomization failures that currently happen with this change (but I can't do anything for the seeds where it's legitimately impossible)

Din's Pearl

In 1.6.0, the effect of Din's pearl on the lava pool in front of the entrance was removed, so that there's always a bomb puzzle to solve to enter DRC. Since this PR adds another puzzle anyway, I removed this patch when the boulder is present (additionally, it makes it easier to cross with the leaf, as it calms the wind, making Din's pearl a useful QoL item)
I'm happy to remove that if not desired

<item>
<widget class="QGroupBox" name="groupBox_logic_tweaks">
<property name="title">
<string>Logic Tweaks</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be called something different since it affects things in game and not just the logic? This option seems similar to "Skip Boss Rematches", but isn't really a convenience tweak

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely, this spot in the UI is mostly a placeholder since I don't really know what would make the most sense to group it up with.
I hadn't thought about skip rematch bosses but it does feel very close. If this option is considered ok to not be in the advanced tab then grouping these 2 together would make sense. I'm really not sure either way about having it in the advanced tab, on one hand it does match the vanilla game so it's not especially advanced, but the possible randomization failures might disqualify it

Required bosses mode is also similar (changes logic requirements of entering PG) but that has its own category
In some way, keylunacy and swordless mode are also somewhat similar in changing item requirements and some game mechanics, but they're wider scope than a single area in the game.

This is definitely one of the point I was hoping for feedback on anyway, thanks for reminding me of skip rematch bosses

@wooferzfg
Copy link
Contributor

With this setting being in the Advanced Options tab, hopefully the additional randomization failures are okay. It seems like a tricky problem to avoid randomization failures in every case

Replace the boulder that can only be broken with bomb flowers with a
standard boulder
Catch some cases where the item randomizer won't be able to place the
first item and error out early with an actionable error message

This is not comprehensive, and might have false positives with
extra starting items due to the fairly static safety entrance
algorithm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants