[Enhancement] Now allow for custom implementations of EventWaiter #59
+261
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shengaero
added
Enhancement
|
This newest commit should also address #60 |
…ttps://github.com/JDA-Applications/JDA-Utilities into enhancement/event-waiter-interface
…ttps://github.com/JDA-Applications/JDA-Utilities into enhancement/event-waiter-interface
|
Any help needed to move this PR along? Suffering from #60 |
|
@napstr if you absolutely need this PR right now, you can check it out via jitpack. |
Sanduhr32
reviewed
May 6, 2019
| */ | ||
| public EventWaiter(boolean threadSafe) | ||
| { | ||
| this(Executors.newSingleThreadScheduledExecutor(), true, true); |
There was a problem hiding this comment.
Not using the local threadSafe for calling the overloaded constructor.
Suggested change
| this(Executors.newSingleThreadScheduledExecutor(), true, true); | |
| this(Executors.newSingleThreadScheduledExecutor(), true, threadSafe); |
|
Just wanted to point out that the linked Gist is invalid (doesn't exist) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Pull Request Checklist
Please follow the following steps before opening this PR.
PRs that do not complete the checklist will be subject to denial for
missing information.
or merged features/bug fixes.
Pull Request Information
Check and fill in the blanks for all that apply:
commonsmodule of the JDA-Utilities library.______.Description
Due to the recent EventWaiter requests (among them, asynchronous dispatch of
EventListener#onEvent, concurrent-modification support, and others I am probably missing), there will now be a new interface as part of thecommonsmodule:IEventWaiterThis will allow for developers to have even the tiniest specifications they might desire at their disposal when dealing with the menus in the
menumodule, and other general specifics.An example implementation in kotlin can be found here.
Please note that if you currently use
EventWaiterthis PR is 100% backwards compatible, and you should have no codebase changes required upon the release of next version.