Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frankenphp 1.2.5 (new formula) #194717

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

dunglas
Copy link

@dunglas dunglas commented Oct 17, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This formula builds a static binary of FrankenPHP that embeds PHP. It's not possible to depend on the PHP provided by Brew because it doesn't provide libphp and it is not compiled with ZTS support, which is required for FrankenPHP.

It should be interesting to rebuild this formula when a new release of PHP is available, but I'm not sure of how to achieve this. Alternatively, it could be better to create a cask and download the static binary build each night upstream, that contains up-to-date versions of the dependencies.

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core php PHP use is a significant feature of the PR or issue labels Oct 17, 2024
@dunglas dunglas changed the title frankenphpfrankenphp 1.2.5 (new formula)) frankenphp 1.2.5 (new formula)) Oct 17, 2024
@dunglas dunglas changed the title frankenphp 1.2.5 (new formula)) frankenphp 1.2.5 (new formula) Oct 17, 2024
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@stefanb
Copy link
Member

stefanb commented Oct 17, 2024

Error: ../libtool: line 1733: x86_64-linux-musl-ar: command not found

@SMillerDev
Copy link
Member

It's self-submitted, compiles it's own version of Homebrew formula, I think you should consider hosting it in a personal tap instead, which is very easy to do: https://docs.brew.sh/How-to-Create-and-Maintain-a-Tap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core php PHP use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants