Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sf 2.61.8 (new formula) #194653

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

catalandres
Copy link

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added nodejs Node or npm use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Oct 16, 2024
@catalandres
Copy link
Author

catalandres commented Oct 16, 2024

There exists a cask for the same tool.

Salesforce provides two paths to installation: a binary and an NPM package. The binary comes packaged with its own version of Node, which is extremely inefficient and redundant for Brew users. brew install sf should install the NPM package, and users should have the option to install the complete binary with brew install sf --cask.

Formula/s/sf.rb Outdated Show resolved Hide resolved
Formula/s/sf.rb Outdated Show resolved Hide resolved
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

Formula/s/sf.rb Outdated Show resolved Hide resolved
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 16, 2024
@github-actions github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Oct 16, 2024
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Oct 16, 2024
Formula/s/sf.rb Outdated Show resolved Hide resolved
@chenrui333 chenrui333 removed the ready to merge PR can be merged once CI is green label Oct 16, 2024
@catalandres catalandres force-pushed the formula-sf branch 4 times, most recently from 0f01c73 to 4f29490 Compare October 17, 2024 00:31
@stefanb
Copy link
Member

stefanb commented Oct 17, 2024

btw, you don't have to rebase it unless you need to resolve a conflict

@catalandres
Copy link
Author

Understood — newb here: long time listerner, first time caller 🙂

@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new formula PR adds a new formula to Homebrew/homebrew-core nodejs Node or npm use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants